Bug 203266 - audio/squeezeboxserver: changes newsyslog.conf on installation
Summary: audio/squeezeboxserver: changes newsyslog.conf on installation
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Ben Woods
URL: https://reviews.freebsd.org/D6483
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-22 19:34 UTC by Dmitry Marakasov
Modified: 2016-10-05 22:53 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (markk)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Marakasov freebsd_committer freebsd_triage 2015-09-22 19:34:24 UTC 
squeezeboxserver changes /etc/newsyslog.conf which is incorrect and leads to stage-qa errors:

http://poudriere.amdmi3.ru/data/10-amd64-default/failures_all_2015_09_20/logs/errors/squeezeboxserver-7.5.4_9.log

Instead, it should install plain file into ${PREFIX}/etc/newsyslog.conf.d, so it is automatically included by newsyslog.conf.

Also the log shows problems while creating a log file - it probably lacks mkdir, and should better be performed from rc.d script anyway.
Comment 1 Martin Wilke freebsd_committer freebsd_triage 2016-01-18 06:37:05 UTC 
Hi,

Any progress here?
Comment 2 Ben Woods freebsd_committer freebsd_triage 2016-05-21 07:18:34 UTC 
I have put a diff up for revision on phabricator for moving the audio/squeezeboxserver port to audio/logitechmediaserver. It also includes fixes for this bug report (no longer edits /etc/newsyslog.conf, but instead adds a file to /usr/local/etc/newsyslog.conf.d/:
https://reviews.freebsd.org/D6483

markk: as the maintainer of this port, can I please get you to review, test and approve the change in the revision? The easiest way would be for you to create a phabricator account and provide feedback directly on the review. Alternatively, you could provide comments here in the bug report.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-10-05 22:51:09 UTC 
A commit references this bug:

Author: woodsb02
Date: Wed Oct  5 22:50:28 UTC 2016
New revision: 423393
URL: https://svnweb.freebsd.org/changeset/ports/423393

Log:
  Move audio/squeezeboxserver to audio/logitechmediaserver

  audio/squeezeboxserver:
  - Move to audio/logitechmediaserver
  - Update to 7.9.0 pre-release (git commit from 7.9 branch on 2016.09.30)
  - Change default install and database locations to suit new PORTNAME
  - Remove softsqueeze.sh as it is no longer bundled with the server
  - Add /usr/local/etc/newsyslog.conf.d/, don't edit /etc/newsyslog.conf
  - Add LICENSE details
  - Update maintainer (previous maintainer timeout)
  - Use customized perl modules provided in distfile and slimserver-vendor
    GitHub repo, rather than using perl dependencies from ports
  - Changed install method to now copy directly to stagedir instead of an
    intermediate step to TMP_SLIMDIR

  audio/squeezeboxserver-dynamicplaylist:
  - Move to audio/logitechmediaserver-dynamicplaylist
  - Update to 2.9.3853
  - Fix MASTER_SITES
  - Add LICENSE details
  - Update maintainer

  audio/squeezeboxserver-lazysearch:
  - Move to audio/logitechmediaserver-lazysearch
  - Add LICENSE details
  - Update maintainer

  audio/squeezeboxserver-sqlplaylist:
  - Move to audio/logitechmediaserver-sqlplaylist
  - Update to 2.5.3859
  - Fix MASTER_SITES
  - Add LICENSE details
  - Update maintainer

  audio/squeezeboxserver-superdatetime:
  - Move to audio/logitechmediaserver-superdatetime
  - Add LICENSE details
  - Update maintainer

  audio/squeezeboxserver-trackstat:
  - Move to audio/logitechmediaserver-trackstat
  - Update to 3.2.3951
  - Fix MASTER_SITES
  - Add LICENSE details
  - Update maintainer

  PR:		180034
  PR:		203266
  Submitted by:	woodsb02, mark@tranquillussoftware.co.uk (new maintainer)
  Reported by:	david@dawninglight.net, amdmi3
  Approved by:	markk@knigma.org (maintainer timeout), tdb (maintainer), adamw (mentor)
  Differential Revision:	https://reviews.freebsd.org/D6483

Changes:
  head/MOVED
  head/UPDATING
  head/audio/Makefile
  head/audio/logitechmediaserver/
  head/audio/logitechmediaserver/Makefile
  head/audio/logitechmediaserver/distinfo
  head/audio/logitechmediaserver/files/Custom.pm.in
  head/audio/logitechmediaserver/files/logitechmediaserver.conf.in
  head/audio/logitechmediaserver/files/logitechmediaserver.in
  head/audio/logitechmediaserver/files/patch-Slim_Utils_Log.pm
  head/audio/logitechmediaserver/files/patch-convert.conf
  head/audio/logitechmediaserver/files/patch-dbix-class-bug.diff
  head/audio/logitechmediaserver/files/patch-modules.conf
  head/audio/logitechmediaserver/files/softsqueeze.sh.in
  head/audio/logitechmediaserver/files/squeezeboxserver.in
  head/audio/logitechmediaserver/files/vendorpatch-CPAN_buildme.sh
  head/audio/logitechmediaserver/pkg-descr
  head/audio/logitechmediaserver/pkg-plist
  head/audio/logitechmediaserver-dynamicplaylist/
  head/audio/logitechmediaserver-dynamicplaylist/Makefile
  head/audio/logitechmediaserver-dynamicplaylist/distinfo
  head/audio/logitechmediaserver-dynamicplaylist/pkg-descr
  head/audio/logitechmediaserver-lazysearch/
  head/audio/logitechmediaserver-lazysearch/Makefile
  head/audio/logitechmediaserver-lazysearch/distinfo
  head/audio/logitechmediaserver-lazysearch/pkg-descr
  head/audio/logitechmediaserver-sqlplaylist/
  head/audio/logitechmediaserver-sqlplaylist/Makefile
  head/audio/logitechmediaserver-sqlplaylist/distinfo
  head/audio/logitechmediaserver-sqlplaylist/pkg-descr
  head/audio/logitechmediaserver-sqlplaylist/pkg-plist
  head/audio/logitechmediaserver-superdatetime/
  head/audio/logitechmediaserver-superdatetime/Makefile
  head/audio/logitechmediaserver-superdatetime/distinfo
  head/audio/logitechmediaserver-superdatetime/pkg-descr
  head/audio/logitechmediaserver-trackstat/
  head/audio/logitechmediaserver-trackstat/Makefile
  head/audio/logitechmediaserver-trackstat/distinfo
  head/audio/logitechmediaserver-trackstat/pkg-descr
  head/audio/logitechmediaserver-trackstat/pkg-plist
  head/audio/squeezeboxserver/
  head/audio/squeezeboxserver-dynamicplaylist/
  head/audio/squeezeboxserver-lazysearch/
  head/audio/squeezeboxserver-sqlplaylist/
  head/audio/squeezeboxserver-superdatetime/
  head/audio/squeezeboxserver-trackstat/
Comment 4 Ben Woods freebsd_committer freebsd_triage 2016-10-05 22:53:40 UTC 
Committed, thanks for reporting this Dmitry.