Bug 203281 - news/inn fails to build
Summary: news/inn fails to build
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Johan van Selst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-23 10:33 UTC by Victor Sudakov
Modified: 2015-10-11 10:21 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (johans)

Attachments
poudriere build fail log (33.49 KB, text/plain)
2015-09-23 10:33 UTC, Victor Sudakov 		no flags Details
proposed patch (480 bytes, patch)
2015-09-23 11:39 UTC, Johan van Selst 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Sudakov 2015-09-23 10:33:18 UTC 
Created attachment 161298 [details]
poudriere build fail log

news/inn (inn-2.6.0) fails to build both on 93amd64 and 93i386 with

getmodaddr.c: In function 'GetModeratorAddress':
getmodaddr.c:204: error: #pragma GCC diagnostic not allowed inside functions
getmodaddr.c:206: error: #pragma GCC diagnostic not allowed inside functions
getmodaddr.c:226: error: #pragma GCC diagnostic not allowed inside functions
getmodaddr.c:228: error: #pragma GCC diagnostic not allowed inside functions
Makefile:67: recipe for target 'getmodaddr.o' failed
gmake[1]: *** [getmodaddr.o] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/news/inn/work/inn-2.6.0/lib'
Makefile:57: recipe for target 'all-lib' failed
gmake: *** [all-lib] Error 2
*** [do-build] Error code 1

Stop in /usr/ports/news/inn.
====>> Cleaning up wrkdir
===>  Cleaning for inn-2.6.0
build of news/inn ended at Wed Sep 23 17:05:17 NOVT 2015
build time: 00:00:16
!!! build failure encountered !!!

attached please find the complete poudriere log.
Comment 1 Johan van Selst freebsd_committer freebsd_triage 2015-09-23 11:38:42 UTC 
Sounds like ccache is not supported. It works fine with gcc or clang here.
The following patch should fix it by removing all #pragma lines.
Please let me know if this works for you
Comment 2 Johan van Selst freebsd_committer freebsd_triage 2015-09-23 11:39:17 UTC 
Created attachment 161303 [details]
proposed patch
Comment 3 Victor Sudakov 2015-09-23 12:47:52 UTC 
For some reason the patch does not apply to news/inn/Makefile

[root@svn64 ports/news/inn] patch -C < /tmp/q.patch
Hmm...  Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|--- Makefile   (revision 397609)
|+++ Makefile   (working copy)
--------------------------
Patching file Makefile using Plan A...
Hunk #1 failed at 158.
1 out of 1 hunks failed--saving rejects to Makefile.rej
done
[root@svn64 ports/news/inn]
Comment 4 Victor Sudakov 2015-09-23 16:26:23 UTC 
Ah, this was whitespaces vs tabs. "patch -l" does the job.

And the patch has fixed the problem, the port is now build all right. Thank you, Johan!
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-10-11 10:20:03 UTC 
A commit references this bug:

Author: johans
Date: Sun Oct 11 10:19:26 UTC 2015
New revision: 399083
URL: https://svnweb.freebsd.org/changeset/ports/399083

Log:
  Remove #pragma to fix build with all compiler versions

  PR:		ports/203281

Changes:
  head/news/inn/Makefile
Comment 6 Johan van Selst freebsd_committer freebsd_triage 2015-10-11 10:21:09 UTC 
Sorry for the delay, patch committed now.