Bug 203380 - [patch] security/sudo configure fails with world built WITHOUT_SSP
Summary: [patch] security/sudo configure fails with world built WITHOUT_SSP
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Renato Botelho
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-09-26 16:26 UTC by Kenneth Salerno
Modified: 2016-06-11 20:15 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (garga)

Attachments
Remove redundant lssp_nonshared (269 bytes, patch)
2015-09-26 16:26 UTC, Kenneth Salerno 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Salerno 2015-09-26 16:26:35 UTC 
Created attachment 161440 [details]
Remove redundant lssp_nonshared

Makefile for security/sudo unnecessarily forces -lssp_nonshared when /usr/lib/libc.so already includes this for every link:

> cat /usr/lib/libc.so
/* $FreeBSD: releng/10.1/lib/libc/libc.ldscript 258398 2013-11-20 20:24:59Z peter $ */
GROUP ( /lib/libc.so.7 /usr/lib/libc_nonshared.a /usr/lib/libssp_nonshared.a )

When a user builds world WITHOUT_SSP the library /usr/lib/libssp_nonshared.a does not exist. Do not force this library for sudo, it is automatic.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-06-11 20:11:26 UTC 
A commit references this bug:

Author: garga
Date: Sat Jun 11 20:11:14 UTC 2016
New revision: 416749
URL: https://svnweb.freebsd.org/changeset/ports/416749

Log:
  - Stop forcing -lssp_nonshared since libc already include it in every link.
    It should fix build when world is built with WITHOUT_SSP
  - Bump PORTREVISION

  PR:		203380
  Submitted by:	Kenneth Salerno <kennethsalerno@yahoo.com>
  Sponsored by:	Rubicon Communications (Netgate)

Changes:
  head/security/sudo/Makefile