Bug 203700 - [PATCH] net/turnserver: Fix build with No-SSLv3
Summary: [PATCH] net/turnserver: Fix build with No-SSLv3
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Kubilay Kocak
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-10-11 14:59 UTC by cpbsdmail
Modified: 2015-10-20 06:40 UTC (History)
2 users (show)

See Also:
mom040267: maintainer-feedback+
koobs: merge-quarterly+


Attachments
svn diff for net/turnserver (697 bytes, patch)
2015-10-11 14:59 UTC, cpbsdmail
koobs: maintainer-approval+
Details | Diff
svn diff for net/turnserver (694 bytes, patch)
2015-10-11 15:00 UTC, cpbsdmail
koobs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description cpbsdmail 2015-10-11 14:59:27 UTC
Created attachment 161912 [details]
svn diff for net/turnserver

turnserver will not build if OpenSSL was built without SSLv3 (--no-ssl3).

LibreSSL 2.3.0 has removed SSLv3 support completely.

- Fix build without SSLv3
Comment 1 cpbsdmail 2015-10-11 15:00:28 UTC
Created attachment 161913 [details]
svn diff for net/turnserver
Comment 2 mom040267 2015-10-11 16:02:01 UTC
Both attached patches are needed to build turnserver without SSLv3 support.
I approve that change.
Comment 3 mom040267 2015-10-12 01:48:12 UTC
I am going to add compatibility with LibreSSL 2.3.0 to the turnserver version 4.5.0.3.
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 10:50:50 UTC
We normally require diffs against ports, not the upstream sources. Specifically with patches in files/, they can be generated automatically via `make makepatch`. 

For more details see: https://www.freebsd.org/doc/en/books/porters-handbook/slow-patch.html
Comment 5 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 11:04:05 UTC
====> Running Q/A tests (stage-qa)
Warning: port uses /usr/local/var instead of /var

Maintainer, you probably want to address this using --localstatedir or similar, which appears to be supported in the configure script, in your next port update.

The port also doesn't appear to honour CFLAGS (appending its own flags, rather than prepending them)
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-10-19 11:07:49 UTC
A commit references this bug:

Author: koobs
Date: Mon Oct 19 11:06:51 UTC 2015
New revision: 399657
URL: https://svnweb.freebsd.org/changeset/ports/399657

Log:
  net/turnserver: Fix build with No-SSLv3

  turnserver will not build if OpenSSL was built without SSLv3
  (--no-ssl3).

  LibreSSL 2.3.0 has removed SSLv3 support completely.

  This change fixes the build when SSLv3 is not available

  While I'm here, add LICENSE_FILE

  PR:		203700
  Submitted by:	cpbsdmail gmail com
  Approved by:	mom040267 gmail com (maintainer)
  MFH:		2014Q4

Changes:
  head/net/turnserver/Makefile
  head/net/turnserver/files/patch-src_apps_common_apputils.c
  head/net/turnserver/files/patch-src_apps_uclient_mainuclient.c
Comment 7 commit-hook freebsd_committer freebsd_triage 2015-10-19 11:11:51 UTC
A commit references this bug:

Author: koobs
Date: Mon Oct 19 11:10:51 UTC 2015
New revision: 399658
URL: https://svnweb.freebsd.org/changeset/ports/399658

Log:
  MFH: r399657

  net/turnserver: Fix build with No-SSLv3

  turnserver will not build if OpenSSL was built without SSLv3
  (--no-ssl3).

  LibreSSL 2.3.0 has removed SSLv3 support completely.

  This change fixes the build when SSLv3 is not available

  While I'm here, add LICENSE_FILE

  PR:		203700
  Submitted by:	cpbsdmail gmail com
  Approved by:	mom040267 gmail com (maintainer)

  Approved by:	portmgr (erwin)

Changes:
_U  branches/2014Q4/
  branches/2014Q4/net/turnserver/Makefile
  branches/2014Q4/net/turnserver/files/patch-src_apps_common_apputils.c
  branches/2014Q4/net/turnserver/files/patch-src_apps_uclient_mainuclient.c
Comment 8 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 11:12:24 UTC
Committed with a minor addition, thank you!
Comment 9 Kubilay Kocak freebsd_committer freebsd_triage 2015-10-19 13:07:11 UTC
Incorrectly merged to 2014Q4 (instead of 2015Q4) - Standby for proper MFH
Comment 10 commit-hook freebsd_committer freebsd_triage 2015-10-19 13:35:05 UTC
A commit references this bug:

Author: koobs
Date: Mon Oct 19 13:34:34 UTC 2015
New revision: 399669
URL: https://svnweb.freebsd.org/changeset/ports/399669

Log:
  MFH: r399657

  net/turnserver: Fix build with No-SSLv3

  turnserver will not build if OpenSSL was built without SSLv3
  (--no-ssl3).

  LibreSSL 2.3.0 has removed SSLv3 support completely.

  This change fixes the build when SSLv3 is not available

  While I'm here, add LICENSE_FILE

  PR:		203700
  Submitted by:	cpbsdmail gmail com
  Approved by:	mom040267 gmail com (maintainer)

  Approved by:	portmgr (erwin)

Changes:
_U  branches/2015Q4/
  branches/2015Q4/net/turnserver/Makefile
  branches/2015Q4/net/turnserver/files/patch-src_apps_common_apputils.c
  branches/2015Q4/net/turnserver/files/patch-src_apps_uclient_mainuclient.c
Comment 11 mom040267 2015-10-20 06:40:02 UTC
Thank you for that update and for the suggestions.