Bug 203980 - [patch] mail/p5-Email-Sender-Transport-SMTP-TLS: Update to 0.15
Summary: [patch] mail/p5-Email-Sender-Transport-SMTP-TLS: Update to 0.15
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-ports-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-10-23 12:17 UTC by Torsten Zühlsdorff
Modified: 2015-11-25 06:13 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (ale)

Attachments
patch with update to 0.15 (1.61 KB, patch)
2015-10-23 12:17 UTC, Torsten Zühlsdorff 		no flags Details | Diff
poudriere log (18.37 KB, text/x-log)
2015-10-23 12:18 UTC, Torsten Zühlsdorff 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Torsten Zühlsdorff 2015-10-23 12:17:51 UTC 
Created attachment 162389 [details]
patch with update to 0.15

Hello,

attached a patch to update this port to current version 0.15. While there:
- add LICENSE
- fix wrong url in pkg-descr
- make portlint -C happy

Greetings,
Torsten
Comment 1 Torsten Zühlsdorff 2015-10-23 12:18:08 UTC 
Created attachment 162390 [details]
poudriere log
Comment 2 Kurt Jaeger freebsd_committer freebsd_triage 2015-10-24 19:42:57 UTC 
The only change is

DEPRECATED in favor of Email::Sender::Transport::SMTPS (no code changes, it still works)

Is this update really necessary ?
Comment 3 Torsten Zühlsdorff 2015-10-26 12:44:15 UTC 
(In reply to Kurt Jaeger from comment #2)

> Is this update really necessary?

That is a good question i also asked myself before creating the PR.

At least i think: yes. The patch adds the missing license and fix the wrong URL in pkg-descr. I thinks this is already sufficient. 

Also i believe the update is worthy, because the module deprecates itself. While still usable the user should know there is a better approach to use.

Also we may consider to set an expiration date for this port. Its deprecated since 2 years and if there are no ports depending on it, it should be safe to remove it from the portstree.
Comment 4 commit-hook freebsd_committer freebsd_triage 2015-11-25 06:12:08 UTC 
A commit references this bug:

Author: wen
Date: Wed Nov 25 06:11:22 UTC 2015
New revision: 402389
URL: https://svnweb.freebsd.org/changeset/ports/402389

Log:
  - Update to 0.15
  - Add LICENSE
  - Pet portlint

  PR:		203980
  Submitted by:	ports@toco-domains.de
  Approved by:	maintainer(timeout, >30 days)

Changes:
  head/mail/p5-Email-Sender-Transport-SMTP-TLS/Makefile
  head/mail/p5-Email-Sender-Transport-SMTP-TLS/distinfo
  head/mail/p5-Email-Sender-Transport-SMTP-TLS/pkg-descr