Bug 204113 - [MAINTAINER] dns/dnsdist: Update to 0.0.336gc278ffd, fix MASTER_SITES
Summary: [MAINTAINER] dns/dnsdist: Update to 0.0.336gc278ffd, fix MASTER_SITES
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Unovitch
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-10-29 01:58 UTC by Carlos J Puga Medina
Modified: 2015-10-30 02:02 UTC (History)
2 users (show)

See Also:


Attachments
v0 (1.16 KB, patch)
2015-10-29 01:58 UTC, Carlos J Puga Medina
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos J Puga Medina 2015-10-29 01:58:57 UTC
Created attachment 162554 [details]
v0

- Update to 0.0.336gc278ffd
- Fix MASTER_SITES
Comment 1 Jason Unovitch freebsd_committer freebsd_triage 2015-10-29 02:16:31 UTC
Carlos,
Why can't we use the upstream mirror here?  I would prefer to use upstream where possible rather than point at personal servers.
Comment 2 Carlos J Puga Medina 2015-10-29 02:29:46 UTC
(In reply to Jason Unovitch from comment #1)

Hi Jason,

Kurt told me to do this via email :)

I will try to convince dnsdist people to make it available via upstream because it seems that old distfiles are removed quickly. See bug 203613 for further details.
Comment 3 Jason Unovitch freebsd_committer freebsd_triage 2015-10-29 03:06:40 UTC
(In reply to Carlos J Puga Medina from comment #2)
Ok, that makes sense.  Alternately we can use LOCAL.  See dns/tinystats/Makefile for an example.  I can place the distfile in my user account and it will be available as a mirror.  I was hoping to see this documented in https://www.FreeBSD.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html but it seems it's not and we need a patch for the porter's handbook.

The policy to remove distfiles upstream does make some things a challenge.  We do have the distfile cache but you won't know if the drift between quarterly/head ends up breaking fetch.  The SVN tags for each release cut in https://svnweb.FreeBSD.org/ports/tags/ may end up less useful over time if the upstream distfiles are done.
Comment 4 Jason Unovitch freebsd_committer freebsd_triage 2015-10-29 03:14:28 UTC
portlint -ac:
  looks fine.

QA Poudriere builds will take time and sleep is happening now.  I'll finish up and commit tomorrow.
Comment 5 Carlos J Puga Medina 2015-10-29 03:16:42 UTC
(In reply to Jason Unovitch from comment #3)

Perfect! Please, upload the new distfile and let me know to accordingly change the MASTER_SITES.
Comment 6 commit-hook freebsd_committer freebsd_triage 2015-10-30 01:59:01 UTC
A commit references this bug:

Author: junovitch
Date: Fri Oct 30 01:58:14 UTC 2015
New revision: 400487
URL: https://svnweb.freebsd.org/changeset/ports/400487

Log:
  dns/dnsdist: 0.0.281gade4ced -> 0.0.336gc278ffd

  - Also add maintainer mirror and LOCAL as a fallback. Upstream only seems
    to keep the last 50 distfiles on their mirrors and this has broken fetch
    in the past (see bug 203613).

  PR:		204113
  Submitted by:	Carlos J Puga Medina <cpm@fbsd.es> (maintainer)

Changes:
  head/dns/dnsdist/Makefile
  head/dns/dnsdist/distinfo
Comment 7 Jason Unovitch freebsd_committer freebsd_triage 2015-10-30 02:02:54 UTC
(In reply to Carlos J Puga Medina from comment #5)
Don't worry about it.  It's easier to just fix it pre-commit.

Note that I left the upstream mirror as the first MASTER_SITE so it gets hit first.  We can just let it fall back to your mirror or the FreeBSD distcache when the upstream inevitably removes the distfile.  This should hopefully reduce the load on your server.

QA -- for the archives:

% portlint -ac
looks fine.

Poudriere tested successfully on:
9.3-RELEASE-p28      amd64
9.3-RELEASE-p28      i386
10.1-RELEASE-p22     amd64
10.1-RELEASE-p22     i386
10.2-RELEASE-p5      amd64
10.2-RELEASE-p5      i386
11.0-CURRENT r289912 amd64
11.0-CURRENT r289912 i386