Bug 204381 - multimedia/kodi: Add PULSEAUDIO option
Summary: multimedia/kodi: Add PULSEAUDIO option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: easy, needs-qa, patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-11-09 00:49 UTC by Yuri Victorovich
Modified: 2015-12-08 16:49 UTC (History)
1 user (show)

See Also:
koobs: maintainer-feedback+
koobs: merge-quarterly?

Attachments
patch (1.45 KB, patch)
2015-11-09 00:49 UTC, Yuri Victorovich 		koobs: maintainer-approval+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuri Victorovich freebsd_committer freebsd_triage 2015-11-09 00:49:28 UTC 
Created attachment 162912 [details]
patch

Since in my experience many FreeBSD desktops run PulseAudio, it is good to have it enabled.

Testing I did: ran it and saw it playing through the PulseAudio, when before it used OSS.
Comment 1 mickael.maillot 2015-11-25 16:40:27 UTC 
Looks good to me, if you have tested it on real hardware it's perfect.
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-27 02:50:20 UTC 
@Yuri Confirmation this passes QA would be great. 

Also, should/would we like this to be merged to the quarterly branch? It's a good candidate
Comment 3 Yuri Victorovich freebsd_committer freebsd_triage 2015-11-28 16:26:27 UTC 
I verified, PULSEAUDIO works on real system.
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 08:57:39 UTC 
Take.
Comment 5 commit-hook freebsd_committer freebsd_triage 2015-12-08 16:49:07 UTC 
A commit references this bug:

Author: miwi
Date: Tue Dec  8 16:48:23 UTC 2015
New revision: 403296
URL: https://svnweb.freebsd.org/changeset/ports/403296

Log:
  - Add PULSEAUDIO knob

  PR:		204381
  Submitted by:    yuri@rawbw.com
  Approved by:	mat (mentor), maintainer timeout 3 weeks+
  Differential Revision:	https://reviews.freebsd.org/D4432

Changes:
  head/multimedia/kodi/Makefile