Bug 204418 - lang/rust-nightly: Update to 1.6.0
Summary: lang/rust-nightly: Update to 1.6.0
Status: Closed Overcome By Events
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jean-Sébastien Pédron
URL: https://reviews.freebsd.org/D3491
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-10 06:25 UTC by will
Modified: 2016-03-29 18:01 UTC (History)
4 users (show)

See Also:
bugzilla: maintainer-feedback? (dumbbell)

Attachments
bump for rust-nightly (6.91 KB, patch)
2015-11-10 06:25 UTC, will 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description will 2015-11-10 06:25:49 UTC 
Created attachment 162947 [details]
bump for rust-nightly
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 13:48:22 UTC 
This appears to have reached maintainer timeout (23 days)

@dumbbell, can I open this up?
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 13:49:36 UTC 
@Will, if you could confirm this passes QA (portlint, poudriere) that would be fantastic.

I know a number of users (via IRC) who would love to play with this via packages, and confidence in the build may be exactly what dumbbell@ needs to get this in quickly
Comment 3 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-12-02 14:07:30 UTC 
Hi!

I would love to update this port more often, but it usually takes too much time to get an approval to commit it.

I have this review which is not outdate anyway:
https://reviews.freebsd.org/D3491

I notice just now that you approved it, koobs@, but the review is still listed in the "Waiting on Others" view on Phabricator so I missed your approval...
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-03 07:07:34 UTC 
(In reply to Jean-Sébastien Pédron from comment #3)

Since you're set as MAINTAINER, reviews are technically a formality and approval (from anyone else) is not *strictly* a requirement.

If you're happy with the changeset and QA (poudriere, etc), there's no need to wait on others, though since Will (wca@) has a put much time into rust ports, it's certainly 'nice' to get everyone's input.

Down the track, a rust@ team alias might be handy so that anyone on the team (recipients list) can commit updates to the port
Comment 5 Jean-Sébastien Pédron freebsd_committer freebsd_triage 2015-12-03 07:15:01 UTC 
I didn't mean I wanted someone else to double-check the patch, but I'm not a Ports committer, so I still need an approval from one of you :)

I agree about a rust@team.
Comment 6 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-03 07:19:52 UTC 
(In reply to Jean-Sébastien Pédron from comment #5)

Ah! In that case any ports committer may give you approval (>0).

Though just to be clear, ports committers are technically only approving the 'commit' proposal and the change syntactically, rather than the software specific change semantics.

If the change in D3491 passes poudriere (there's no mention of QA results/logs in the review), you are clear to commit
Comment 7 oleksii.tsai 2016-03-05 17:32:06 UTC 
This patch is no longer relevant, as rust 1.7.0 stable just landed in ports.
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-03-29 18:00:02 UTC 
A commit references this bug:

Author: dumbbell
Date: Tue Mar 29 17:58:59 UTC 2016
New revision: 412126
URL: https://svnweb.freebsd.org/changeset/ports/412126

Log:
  lang/rust-nightly: Update to 1.9.0.20160318

  While here, relevant improvements made to lang/rust were copied.

  PR:		204418, 206091
  Reviewed by:	asomers, jbeich
  Approved by:	asomers, jbeich
  Differential Revision:	https://reviews.freebsd.org/D5766

Changes:
  head/lang/rust-nightly/Makefile
  head/lang/rust-nightly/distinfo
  head/lang/rust-nightly/pkg-plist