Created attachment 163484 [details] patch audacity: add build deps for docs With option DOCS enabled, the build fails. Bash complains about missing command docbook-to-man and docbook2man. Including build dependencies textproc/docbook-to-man and textproc/docbook-utils seem to solve the problem.
(In reply to Rainer Hurling from comment #0) Forgot to say, that Poudriere builds fine with them, but fails without. portlint -AC ok, also.
Since DOC installation is an option, should convert it to DOC_DEPENDS= so it only installs those dependencies if DOC is chosen.
@Jack as per comment 2, does this need an updated patch or is attachment 163484 [details] OK? Please provide clear instructions: approved or not approved for <attachment id> with comment Otherwise this issue is a blanket fix that has implicit (portmgr/ports-secteam) approval
I'll make a new docs options specific patch shortly
(In reply to xxjack12xx from comment #2) Thanks, Jack, I like the idea, to make the docbook-* dependend on the docs option. It would have been better, if my patch implied it under DOC_DEPENDS already. Sorry for missing that.
Created attachment 163575 [details] Patch to add needed depends if DOCS selected
@Jack, attachment 163575 [details] doesn't appear to have the documentation dependencies dependent on DOCS like Rainer's attachment 163484 [details], or am I misunderstanding something?
If you configure the port with the DOCS option selected, it will pull in the dependencies during the build. If DOCS option is not selected, then don't pull in any dependencies that DOCS needs. Does that make sense?
(In reply to xxjack12xx from comment #8) The statement does, but the patch in attachment 163575 [details] doesn't seem to have the 'conditionality' on the DOCS option (or any option). What am I missing?
Doesn't DOCS_BUILD_DEPENDS= only pull in the deps if DOCS is selected?
(In reply to xxjack12xx from comment #10) The patch you approved (attachment 163575 [details]) adds the dependencies to BUILD_DEPENDS, not using DOCS_BUILD_DEPENDS as Rainers patch does (attachment 163484 [details]) If Rainers patch is complete and correct, you can just approve it (in a comment: "I approve attachment 163484 [details]") Your previous comment 4 is what is confusing. If Rainers patch already adds DOCS_BUILD_DEPENDS, why was a new patch needed? Please clarify.
Sorry, in my previous comment I got the attachment id's backwards. Rainers patch (attachment 163484 [details]) uses DOCS_BUILD_DEPENDS (conditional on DOCS option) Your patch (attachment 163575 [details]) uses BUILD_DEPENDS (not conditional on DOCS option)
I think you still have it backwards My attachment 163575 [details] uses DOCS_BUILD_DEPENDS (conditional on DOCS option) Rainers patch attachment 163484 [details] uses BUILD_DEPENDS (conditional on DOCS option)
last line should read unconditional
Whoah, I don't know how that happened Jack, but I checked them multiple times. Thank you for your patience :)
A commit references this bug: Author: riggs Date: Sat Nov 28 14:43:17 UTC 2015 New revision: 402536 URL: https://svnweb.freebsd.org/changeset/ports/402536 Log: Fix build failure with DOCS option and edge case In certain situations, e.g. when docbook ports have been deinstalled before building audacity with DOCS option, build may fail. Prevent this case by explicitly including required docbook ports in DOCS_BUILD_DEPENDS PR: 204785 Submitted by: rhurlin@gwdg.de Reviewed by: xxjack12xx@gmail.com (maintainer) Approved by: xxjack12xx@gmail.com (maintainer) Changes: head/audio/audacity/Makefile