Bug 204896 - net/ladvd: Update to 1.1.0
Summary: net/ladvd: Update to 1.1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: needs-qa, patch
Depends on:
Blocks:
 
Reported: 2015-11-29 16:34 UTC by Mathieu Simon
Modified: 2015-12-28 14:50 UTC (History)
2 users (show)

See Also:
riggs: maintainer-feedback-

Attachments
Patch 1: Update net/ladvd to 1.1.0 (7.71 KB, application/mbox)
2015-11-29 16:34 UTC, Mathieu Simon 		no flags Details
Patch 2: USE_GITHUB (1.50 KB, patch)
2015-11-29 16:35 UTC, Mathieu Simon 		no flags Details | Diff
Update net/ladvd to 1.1.0 + USE_GITHUB (7.96 KB, application/mbox)
2015-11-30 04:02 UTC, Mathieu Simon 		no flags Details
Revised patch including fixes for DOCS and LICENSE* (8.43 KB, text/plain)
2015-12-19 17:03 UTC, Thomas Zander 		riggs: maintainer-approval? (sten)
 Details
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Simon 2015-11-29 16:34:46 UTC 
Created attachment 163652 [details]
Patch 1: Update net/ladvd to 1.1.0

Dear maintainer

Added to this PR is a patchset that updates net/ladvd to 1.1.0.

- Has been runtime tested on 10.2 amd64 where I could verify that a valid 
  LLDP package received by the switch on the other end.
- Poudriere testport has worked for 10.0-10.2 on both i386 and amd64
- After discovering issues with 9.3 on amd64 and fixed by adding extra 
  CFLAGS it passed testport on 9.1-9.3 as well.

Patch 1 Updates udates the port and adds a section for handling amd64 compilation on 9.1-9.3.

Patch 2 is more optional, but moves the distfiles to Github since Google Code is going away in the future and the project page already points to Github. Unfortunately the distfiles on blinkenlights.net and on github have different name (but same checksum).

Looking forward to your feedback,
Mathieu
Comment 1 Mathieu Simon 2015-11-29 16:35:16 UTC 
Created attachment 163653 [details]
Patch 2: USE_GITHUB
Comment 2 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-30 01:10:54 UTC 
@Mathieu, could you combine attachment 163653 [details] and attachment 163652 [details] into a single combined unified diff please?
Comment 3 Mathieu Simon 2015-11-30 04:02:46 UTC 
Created attachment 163669 [details]
Update net/ladvd to 1.1.0 + USE_GITHUB

Here you go, as requested: Same as one patch :-)

-- Mathieu
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2015-11-30 04:07:40 UTC 
Thanks Mathieu!
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2015-12-19 16:26:26 UTC 
Maintainer timeout
Comment 6 Thomas Zander freebsd_committer freebsd_triage 2015-12-19 16:27:42 UTC 
Build failure with DOCS=off.
Comment 7 Thomas Zander freebsd_committer freebsd_triage 2015-12-19 17:03:57 UTC 
Created attachment 164385 [details]
Revised patch including fixes for DOCS and LICENSE*

Revision of previous patch:
- Install LICENSE to canonical location and remove it from DOCS
- Fix plist issue with DOCS=off from previous patch
Comment 8 Thomas Zander freebsd_committer freebsd_triage 2015-12-19 17:04:46 UTC 
Request maintainer feedback for updated patch
Comment 9 Mathieu Simon 2015-12-21 06:52:30 UTC 
Thanks Thomas for these additions, let's see how Sten thinks about.

Looking forward to get it commited.

-- Mathieu
Comment 10 Thomas Zander freebsd_committer freebsd_triage 2015-12-28 14:46:35 UTC 
Maintainer timeout
Comment 11 commit-hook freebsd_committer freebsd_triage 2015-12-28 14:49:24 UTC 
A commit references this bug:

Author: riggs
Date: Mon Dec 28 14:48:58 UTC 2015
New revision: 404655
URL: https://svnweb.freebsd.org/changeset/ports/404655

Log:
  Update to upstream version 1.1.0, fetch distfile from GitHub

  PR:		204896
  Submitted by:	freebsd@simweb.ch
  Reviewed by:	riggs
  Approved by:	maintainer timeout

Changes:
  head/net/ladvd/Makefile
  head/net/ladvd/distinfo
  head/net/ladvd/files/patch-src__cli.c
  head/net/ladvd/files/patch-src__compat__setproctitle.c
  head/net/ladvd/files/patch-src__compat__vis.c
  head/net/ladvd/files/patch-src__compat__vis.h
  head/net/ladvd/files/patch-src__proto__tlv.c
  head/net/ladvd/files/patch-src__util.c
  head/net/ladvd/files/pkg-message.in
  head/net/ladvd/pkg-descr