Bug 204960 - net-im/pidgin-skypeweb: Update to 1.0
Summary: net-im/pidgin-skypeweb: Update to 1.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Martin Wilke
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2015-12-02 10:40 UTC by Andrey Akhmichin
Modified: 2015-12-08 16:53 UTC (History)
0 users

See Also:

Attachments
pidgin-skypeweb.diff (1.81 KB, text/plain)
2015-12-02 10:40 UTC, Andrey Akhmichin 		koobs: maintainer-approval+
Details
pidgin-skypeweb.diff v2 (2.02 KB, patch)
2015-12-03 14:49 UTC, Andrey Akhmichin 		koobs: maintainer-approval+
Details | Diff
Poudriere log for net-im/pidgin-skypeweb on FreeBSD 10.2-RELEASE amd64 (54.72 KB, text/plain)
2015-12-03 14:56 UTC, Andrey Akhmichin 		no flags Details
pidgin-skypeweb.diff v3 (2.03 KB, patch)
2015-12-05 17:53 UTC, Andrey Akhmichin 		no flags Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Akhmichin 2015-12-02 10:40:40 UTC 
Created attachment 163744 [details]
pidgin-skypeweb.diff

- Update to 1.0.

- Use cmake instead of gmake.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2015-12-02 10:49:36 UTC 
Thank you Akhmichin :)

Can you confirm that this change passes QA (portlint, poudriere) please
Comment 2 Andrey Akhmichin 2015-12-03 14:49:14 UTC 
Created attachment 163819 [details]
pidgin-skypeweb.diff v2

Kubilay, i'm updated diff.

dos2unix is needed yet.

# portlint -C
looks fine.
Comment 3 Andrey Akhmichin 2015-12-03 14:56:41 UTC 
Created attachment 163820 [details]
Poudriere log for net-im/pidgin-skypeweb on FreeBSD 10.2-RELEASE amd64
Comment 4 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 08:38:52 UTC 
Take.
Comment 5 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 11:45:19 UTC 
Hi,

This patch is not applying clean;

Patching file Makefile using Plan A...
Hunk #1 failed at 2.
Hunk #2 failed at 17.
2 out of 2 hunks failed--saving rejects to Makefile.rej

Can you please resend a new patch. 


Thanks in Advance.
Comment 6 Andrey Akhmichin 2015-12-05 17:53:42 UTC 
Created attachment 163874 [details]
pidgin-skypeweb.diff v3
Comment 7 Martin Wilke freebsd_committer freebsd_triage 2015-12-05 18:02:32 UTC 
Thanks I'll have a look now.
Comment 8 commit-hook freebsd_committer freebsd_triage 2015-12-08 16:53:08 UTC 
A commit references this bug:

Author: miwi
Date: Tue Dec  8 16:52:43 UTC 2015
New revision: 403300
URL: https://svnweb.freebsd.org/changeset/ports/403300

Log:
  - Update to 1.0

  PR:		204960
  Submitted by:	maintainer
  Approved by:	mat (mentor)
  Differential Revision:	https://reviews.freebsd.org/D4404

Changes:
  head/net-im/pidgin-skypeweb/Makefile
  head/net-im/pidgin-skypeweb/distinfo