Bug 205488 - [PATCH] math/gnuplot: Drop PLOT option.
Summary: [PATCH] math/gnuplot: Drop PLOT option.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Greg Lewis
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2015-12-21 14:36 UTC by Raphael Kubo da Costa
Modified: 2015-12-26 23:48 UTC (History)
0 users

See Also:
glewis: maintainer-feedback+


Attachments
Proposed patch (1.13 KB, patch)
2015-12-21 14:36 UTC, Raphael Kubo da Costa
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Raphael Kubo da Costa freebsd_committer freebsd_triage 2015-12-21 14:36:39 UTC
Created attachment 164456 [details]
Proposed patch

gnuplot completely removed support for the gnugraph and unixplot terminal drivers in 2011. From the one of the ChangeLog files:

> 2011-05-31  Ethan A Merritt  <merritt@u.washington.edu>
> [...]
>         Remove obsolete terminal drivers gnugraph and unixplot. The underlying
>         gnu plotutils library is itself more than 10 years out of date (last
>         release July 2000) and the terminal drivers haven't been upgraded for
>         longer than that. In any event, current gnuplot has better native
>         terminal drivers for the devices supported by unixplot/gnugraph.

In practice, this means the PLOT option is a no-op and the dependency on graphics/plotutils is unnecessary. Indeed, if one looks at the port's build logs in the cluster the following can be seen:

> configure: WARNING: unrecognized options: --without-lisp-files, --with-plot, --disable-thin-splines, --with-wx-config
Comment 1 Greg Lewis freebsd_committer freebsd_triage 2015-12-26 23:07:40 UTC
Looks good to me.  Feel free to commit.
Comment 2 commit-hook freebsd_committer freebsd_triage 2015-12-26 23:48:35 UTC
A commit references this bug:

Author: rakuco
Date: Sat Dec 26 23:47:57 UTC 2015
New revision: 404541
URL: https://svnweb.freebsd.org/changeset/ports/404541

Log:
  Drop PLOT option.

  gnuplot completely removed support for the gnugraph and unixplot terminal
  drivers in 2011. From the one of the ChangeLog files:

  > 2011-05-31  Ethan A Merritt  <merritt@u.washington.edu>
  > [...]
  > Remove obsolete terminal drivers gnugraph and unixplot. The underlying
  > gnu plotutils library is itself more than 10 years out of date (last
  > release July 2000) and the terminal drivers haven't been upgraded for
  > longer than that. In any event, current gnuplot has better native
  > terminal drivers for the devices supported by unixplot/gnugraph.

  In practice, this means the PLOT option is a no-op and the dependency on
  graphics/plotutils is unnecessary. Indeed, if one looks at the port's build
  logs in the cluster the following can be seen:

  configure: WARNING: unrecognized options: --without-lisp-files, --with-plot,
  --disable-thin-splines, --with-wx-config

  PR:		205488
  Approved by:	glewis (maintainer)

Changes:
  head/math/gnuplot/Makefile