Bug 206921 - Setting laggproto fails on 11.0-CURRENT (SIOCSLAGG: Protocol not supported)
Summary: Setting laggproto fails on 11.0-CURRENT (SIOCSLAGG: Protocol not supported)
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Marcelo Araujo
URL: https://reviews.freebsd.org/D5226
Keywords: patch, regression
Depends on:
Blocks:
 
Reported: 2016-02-04 12:17 UTC by Pushkar Kothavade
Modified: 2016-02-25 15:29 UTC (History)
5 users (show)

See Also:
koobs: mfc-stable10?

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pushkar Kothavade 2016-02-04 12:17:16 UTC 
This bug has been found while configuring laggproto none on lagg bundle. 

## Command ##
ifconfig lagg0 laggproto none

## Expected output ##
Command should succeed and laggproto on lagg bundle should be set to none.
Test laggproto using 'ifconfig lagg0' command. 

Marcelo Araujo has suggested following patch for 11.0-CURRENT
https://reviews.freebsd.org/D5076
Comment 1 Marcelo Araujo freebsd_committer freebsd_triage 2016-02-04 12:33:14 UTC 
I will take it... I'm following it together with Pushkar.
Comment 2 Pushkar Kothavade 2016-02-08 07:52:25 UTC 
Hi Marcelo,

I tested your patch, technically it works fine. But the issue is, you are considering 'laggproto none' as a invalid option. 

As per the FreeBSD Lagg man page, 'laggproto none' is a valid configuration option for users. 

Attached patch considers 'laggproto none' as a valid configuration option. 
i.e 'ifconfig lagg2 laggproto none' command should result into success and should apply 'none' protocol to lagg bundle.

Please find fix for 11.0-Current:

https://reviews.freebsd.org/D5226

Test Results:

# ifconfig lagg2 laggproto none

# ifconfig lagg2
lagg2: flags=8802<BROADCAST,SIMPLEX,MULTICAST> metric 0 mtu 1500
	options=8<VLAN_MTU>
	ether 00:0c:29:fb:55:71
	nd6 options=29<PERFORMNUD,IFDISABLED,AUTO_LINKLOCAL>
	media: Ethernet autoselect
	status: no carrier
	groups: lagg 
	laggproto none lagghash l2,l3,l4
	laggport: le1 flags=0<>
	laggport: le2 flags=0<>
	laggport: le3 flags=0<>
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-02-19 06:36:44 UTC 
A commit references this bug:

Author: araujo
Date: Fri Feb 19 06:35:53 UTC 2016
New revision: 295796
URL: https://svnweb.freebsd.org/changeset/base/295796

Log:
  Fix regression introduced on 272446r.

  lagg(4) supports the protocol none, where it disables any traffic without
  disabling the lagg(4) interface itself.

  PR:		206921
  Submitted by:	Pushkar Kothavade <pushkarbk@gmail.com>
  Reviewed by:	rpokala
  Approved by:	bapt (mentor)
  MFC after:	3 weeks
  Sponsored by:	gandi.net
  Differential Revision:	https://reviews.freebsd.org/D5076

Changes:
  head/sys/net/if_lagg.c
Comment 4 Kubilay Kocak freebsd_committer freebsd_triage 2016-02-19 07:04:49 UTC 
Is this only a regression in CURRENT?

If so set mfc-stable10 to - with comment
If not, set mfc-stable10 to + when merged
Comment 5 Marcelo Araujo freebsd_committer freebsd_triage 2016-02-25 15:29:57 UTC 
MFC to stable will be committed right now.