Bug 207646 - security/snortreport unbreak and take maintership
Summary: security/snortreport unbreak and take maintership
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Jason Helfman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-02 15:48 UTC by Zane C. Bowers-Hadley
Modified: 2016-03-03 01:51 UTC (History)
2 users (show)

See Also:
jgh: maintainer-feedback? (vvelox)

Attachments
security_snortreport_Makefile.diff (298 bytes, patch)
2016-03-02 15:48 UTC, Zane C. Bowers-Hadley 		no flags Details | Diff
the proper diff (517 bytes, patch)
2016-03-03 01:12 UTC, Zane C. Bowers-Hadley 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zane C. Bowers-Hadley 2016-03-02 15:48:39 UTC 
Created attachment 167640 [details]
security_snortreport_Makefile.diff

Fixed the MASTER_SITES for this and it downloads again. With that said taking maintership of it as it lacks one.
Comment 1 Jason Helfman freebsd_committer freebsd_triage 2016-03-02 17:08:30 UTC 
Thanks for taking maintainer-ship of this port! Your patch does not fix the port, though. Please address the port so it doesn't break, and submit a diff that makes it build.

I would suggest looking into using github in the ports collection:
https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/makefile-distfiles.html#makefile-master_sites-github-description

Thanks!
-jgh
Comment 2 Zane C. Bowers-Hadley 2016-03-02 17:59:22 UTC 
(In reply to Jason Helfman from comment #1)

I think you replied to the wrong one as the reason it was unfetchable was wrong URL for MASTER_SITES, which this diff fixes. The change is as below per the submitted diff.

-MASTER_SITES=  http://www.symmetrixtech.com/ids/
+MASTER_SITES=  http://symmetrixtech.com/download/

Also the documentation you linked me to is irrelevant as it is not on github.
Comment 3 Jason Helfman freebsd_committer freebsd_triage 2016-03-02 23:25:27 UTC 
The diff attached to this bug notes that github is the place to find the software in the pkg-descr.

Is this diff still valid, or no?
Comment 4 Zane C. Bowers-Hadley 2016-03-03 01:12:17 UTC 
Created attachment 167662 [details]
the proper diff
Comment 5 Zane C. Bowers-Hadley 2016-03-03 01:13:48 UTC 
(In reply to Jason Helfman from comment #3)

Doh! Attached the wrong diff. The one I attached was for fixing the WWW line for barnyard2.

Attached the proper one now. :)

Sorry.
Comment 6 commit-hook freebsd_committer freebsd_triage 2016-03-03 01:38:42 UTC 
A commit references this bug:

Author: jgh
Date: Thu Mar  3 01:38:33 UTC 2016
New revision: 409996
URL: https://svnweb.freebsd.org/changeset/ports/409996

Log:
  - unbreak and pass maintainer-ship to submitter

  PR:		207646
  Submitted by:	vvelox@vvelox.net

Changes:
  head/security/snortreport/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2016-03-03 01:50:45 UTC 
A commit references this bug:

Author: jgh
Date: Thu Mar  3 01:50:34 UTC 2016
New revision: 409998
URL: https://svnweb.freebsd.org/changeset/ports/409998

Log:
  MFH: r409996

  - unbreak and pass maintainer-ship to submitter

  PR:		207646
  Submitted by:	vvelox@vvelox.net
  Approved by:	ports-secteam (with hat)

Changes:
_U  branches/2016Q1/
  branches/2016Q1/security/snortreport/Makefile
Comment 8 Jason Helfman freebsd_committer freebsd_triage 2016-03-03 01:51:49 UTC 
Thanks for the update, and taking the port! This has been committed!