Bug 208094 - installer requirement that disks be at least half zfs is unjustified
Summary: installer requirement that disks be at least half zfs is unjustified
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 10.3-BETA2
Hardware: Any Any
: --- Affects Only Me
Assignee: Allan Jude
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 16:50 UTC by Brooks Davis
Modified: 2016-03-21 19:17 UTC (History)
0 users

See Also:


Attachments
Patch to remove the 'max 50% swap' conditional (2.14 KB, patch)
2016-03-17 17:48 UTC, Allan Jude
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brooks Davis freebsd_committer freebsd_triage 2016-03-17 16:50:24 UTC
The installer's requirement that disks be at least half ZFS makes no sense.  I wanted to install a modest (100GB) zfs root on a couple 1TB SSDs and reserve the rest of the space for L2ARC and ZIL for of the spinning rust in the box, but the installer doesn't provide a way to leave space unused and refuses to allow more than 50% of the disk to be swap (easily recyclable later).  This check seems needlessly paternalistic.

This report is actually against 10.3-RC2, but that's not an option in bugzilla.
Comment 1 Allan Jude freebsd_committer freebsd_triage 2016-03-17 16:53:07 UTC
That conditional was added by dteske, but I see your point.

We can remove that condition. In the future, it might make sense to offer the user the ability to leave unused space, but, we were trying not to clutter the UI with too many options.


I will propose a patch to RE@ and see what they think.
Comment 2 Allan Jude freebsd_committer freebsd_triage 2016-03-17 17:48:47 UTC
Created attachment 168330 [details]
Patch to remove the 'max 50% swap' conditional
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-03-17 17:54:28 UTC
A commit references this bug:

Author: allanjude
Date: Thu Mar 17 17:53:38 UTC 2016
New revision: 296988
URL: https://svnweb.freebsd.org/changeset/base/296988

Log:
  Remove 50% ZFS conditional from bsdinstall/zfsboot

  Remove the requirement that the resulting partition table be atleast 50% ZFS

  PR:		208094
  Requested by:	brooks
  Sponsored by:	ScaleEngine Inc.

Changes:
  head/usr.sbin/bsdinstall/scripts/zfsboot
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-03-17 21:50:01 UTC
A commit references this bug:

Author: allanjude
Date: Thu Mar 17 21:49:20 UTC 2016
New revision: 296997
URL: https://svnweb.freebsd.org/changeset/base/296997

Log:
  MFC: r296996
    Remove 50% ZFS conditional from bsdinstall/zfsboot

  PR:		208094
  Approved by:	re (marius)

Changes:
_U  releng/10.3/
  releng/10.3/usr.sbin/bsdinstall/scripts/zfsboot
Comment 5 Allan Jude freebsd_committer freebsd_triage 2016-03-17 23:30:45 UTC
The fix has been committed, and should ship as part of 10.3-RC3 that will be released tonight/tomorrow.
Comment 6 Brooks Davis freebsd_committer freebsd_triage 2016-03-21 19:17:44 UTC
I've successfully reinstalled my box with RC3 and got more or less the result I wanted.  Being able to specify the amount used by ZFS might be nice eventually.