Bug 208097 - multimedia/kaffeine: DVB functionality has gone since the update to 1.3.1
Summary: multimedia/kaffeine: DVB functionality has gone since the update to 1.3.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: amd64 Any
: --- Affects Some People
Assignee: Tilman Keskinoz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-17 19:26 UTC by Stefan Rumetshofer
Modified: 2016-05-04 09:34 UTC (History)
1 user (show)

See Also:

Attachments
Fix DVB detection (2.52 KB, patch)
2016-05-03 11:46 UTC, Tilman Keskinoz 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Rumetshofer 2016-03-17 19:26:14 UTC 
Since kaffeine was updated to 1.3.1 there is no DVB functionality in the program. But this was the killer feature of kaffeine. The problem begins in the CMakeLists.txt where the variable "HAVE_DVB" is not set, which results with the following output from cmake:

-- Disabled features:
DVB  Digital television support for Linux

This prevents the whole DVB stuff from being built and makes the program useless (for me).

Any chance to get the DVB feature back?
Comment 1 Tilman Keskinoz freebsd_committer freebsd_triage 2016-05-03 11:46:17 UTC 
Created attachment 169925 [details]
Fix DVB detection

I have fixed the broken configure check. 

The port compiles now with DVB Support.

I hacked out the inotify usage, as far as i understand the code it is only used for hotplugin-detection.

I don't have a DVB device. Can You test if the attached patch makes DVB work for you?
Comment 2 Stefan Rumetshofer 2016-05-04 08:22:10 UTC 
(In reply to Tilman Keskinoz from comment #1)
Yes, kaffeine now compiles successfully with DVB support and watching TV is possible again.
Tested with my TechnoTrend TT-connect S2-3650 CI USB Receiver.

Thank you very much.
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-05-04 09:24:09 UTC 
A commit references this bug:

Author: arved
Date: Wed May  4 09:23:20 UTC 2016
New revision: 414596
URL: https://svnweb.freebsd.org/changeset/ports/414596

Log:
  Fix DVB support

  PR:		208097
  Reported by:	Stefan Rumetshofer

  Grab back maintainership

Changes:
  head/multimedia/kaffeine/Makefile
  head/multimedia/kaffeine/files/patch-dmx.h
  head/multimedia/kaffeine/files/patch-dvbdevice_linux.cpp
  head/multimedia/kaffeine/files/patch-frontend.h
Comment 4 Tilman Keskinoz freebsd_committer freebsd_triage 2016-05-04 09:34:56 UTC 
I have committed a fix, thanks for reporting