Bug 208760 - [exp-run] exec.h: Move PS_STRINGS and related #define to kernel-only section
Summary: [exp-run] exec.h: Move PS_STRINGS and related #define to kernel-only section
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Ed Maste
URL: https://reviews.freebsd.org/D5933
Keywords:
Depends on:
Blocks:
 
Reported: 2016-04-13 00:46 UTC by Ed Maste
Modified: 2016-05-11 21:15 UTC (History)
1 user (show)

See Also:

Attachments
exec.h: Move PS_STRINGS define to kernel-only section (19.84 KB, patch)
2016-04-13 00:46 UTC, Ed Maste 		no flags Details | Diff
exec.h: Move PS_STRINGS define to kernel-only section (1.38 KB, patch)
2016-05-02 16:43 UTC, Ed Maste 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Maste freebsd_committer freebsd_triage 2016-04-13 00:46:11 UTC 
Created attachment 169272 [details]
exec.h: Move PS_STRINGS define to kernel-only section

The kern.ps_strings sysctl was introduced in r103767 and the last use of PS_STRINGS in userspace code was removed in r297888.

I would like to see if any ports still depend on it and patch them so that the value can be used in kernel only.
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2016-04-13 05:40:06 UTC 
The patch seems unrelated to the bug report
Comment 2 Ed Maste freebsd_committer freebsd_triage 2016-05-02 16:43:16 UTC 
Created attachment 169883 [details]
exec.h: Move PS_STRINGS define to kernel-only section

Upload correct patch
Comment 3 Ed Maste freebsd_committer freebsd_triage 2016-05-02 16:44:09 UTC 
> The patch seems unrelated to the bug report

Indeed, sorry about that. I'm not sure what happened.
It has now been replaced with the correct patch.
Comment 4 Antoine Brodin freebsd_committer freebsd_triage 2016-05-07 05:31:34 UTC 
Exp-run looks good,  0 new failure.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-05-11 21:15:04 UTC 
A commit references this bug:

Author: emaste
Date: Wed May 11 21:14:36 UTC 2016
New revision: 299482
URL: https://svnweb.freebsd.org/changeset/base/299482

Log:
  exec.h: Move PS_STRINGS define to kernel-only section

  The kern.ps_strings sysctl was introduced in r103767 and the last
  use of PS_STRINGS in userspace code was removed in r297888.

  PR:		208760 [exp-run]
  Reviewed by:	kib
  Sponsored by:	The FreeBSD Foundation
  Differential Revision:	https://reviews.freebsd.org/D5933

Changes:
  head/sys/sys/exec.h