Bug 208996 - [PATCH] sysutils/ansible: make service module respect the sleep option
Summary: [PATCH] sysutils/ansible: make service module respect the sleep option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Guido Falsi
URL: https://github.com/ansible/ansible-mo...
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-04-23 14:34 UTC by Guido Falsi
Modified: 2016-04-23 22:20 UTC (History)
1 user (show)

See Also:
madpilot: maintainer-feedback+

Attachments
patch (1.58 KB, patch)
2016-04-23 14:34 UTC, Guido Falsi 		no flags Details | Diff
Make FreeBSD subclass respect the sleep option. (1.56 KB, patch)
2016-04-23 14:55 UTC, Nikolai Lifanov 		lifanov: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guido Falsi freebsd_committer freebsd_triage 2016-04-23 14:34:15 UTC 
Created attachment 169599 [details]
patch

Hi, I found out I need the sleep options in a few cases on FreeBSD when starting/stopping services, so I slightly modified the module implementation.

I think this could be useful for others too.

I also already submitted a pull request upstream for this:

https://github.com/ansible/ansible-modules-core/pull/3525


Thanks!
Comment 1 Nikolai Lifanov 2016-04-23 14:55:22 UTC 
Created attachment 169601 [details]
Make FreeBSD subclass respect the sleep option.

I approve of the change.

However, please use this patch instead. Otherwise the change also applies to
sysutils/ansible1, where I really don't want to carry local patches.
Comment 2 Guido Falsi freebsd_committer freebsd_triage 2016-04-23 22:09:40 UTC 
(In reply to Nikolai Lifanov from comment #1)
> Created attachment 169601 [details]
> Make FreeBSD subclass respect the sleep option.
> 
> I approve of the change.
> 
> However, please use this patch instead. Otherwise the change also applies to
> sysutils/ansible1, where I really don't want to carry local patches.

Sure, You're right.

I'll commit your patch.
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2016-04-23 22:20:12 UTC 
Committed. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-04-23 22:20:52 UTC 
A commit references this bug:

Author: madpilot
Date: Sat Apr 23 22:19:51 UTC 2016
New revision: 413917
URL: https://svnweb.freebsd.org/changeset/ports/413917

Log:
  Make the service module respect the sleep option.

  PR:		208996
  Submitted by:	me
  Approved by:	Nikolai Lifanov <lifanov at mail.lifanov.com>
  		(maintainer)

Changes:
  head/sysutils/ansible/Makefile
  head/sysutils/ansible/files/extra-patch-8aac5ae