Bug 209799 - misc/kdeedu4: kdeprefix removal too thorough
Summary: misc/kdeedu4: kdeprefix removal too thorough
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Kurt Jaeger
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-05-27 19:08 UTC by groot
Modified: 2016-05-28 07:50 UTC (History)
2 users (show)

See Also:
pi: maintainer-feedback+

Attachments
Add blank USE_KDE4 to metaports that need it (1.17 KB, patch)
2016-05-27 19:08 UTC, groot 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description groot 2016-05-27 19:08:32 UTC 
Created attachment 170733 [details]
Add blank USE_KDE4 to metaports that need it

In r415864, kdeprefix was removed from a whole lot of ports. In a few cases, USE_KDE4= was removed entirely. This happened in some KDE metaports, not in all of them. Many metaports have retained this line:

USE_KDE4=      # blank, needed to get KDE4_VERSION

Attached patch restores this line to three metaports that have lost it entirely. There's two reasons for this:

 - consistency with the other metaports (less important)
 - there are some combinations of OPTIONS that can cause build failures because KDE4_VERSION isn't defined

The latter issue can be illustrated as follows:

 - cd /usr/ports/misc/kdeedu4
 - make config
 - *uncheck* marble
 - portlint, or build

Because of marble (which is enabled by default), usually you get USE_KDE4 set through this line in the Makefile:

MARBLE_USE=             KDE4=marble_run

When marble is unchecked, you get this (from portlint):


FATAL: Makefile: either PORTVERSION or DISTVERSION must be specified
FATAL: Makefile: kdeedu- < kdeedu-4.14.3. Choose another PORTVERSION or bump PORTEPOCH.
Comment 1 groot 2016-05-27 19:15:44 UTC 
Adding rene@ because of


r415864 | rene | 2016-05-25 22:56:06 +0200 (Wed, 25 May 2016) | 10 lines


which introduces this obscure edge case.
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2016-05-27 19:33:20 UTC 
If USE_KDE4 got removed completely, it indeed needs to be re-added with an empty value (or "yes").
Comment 3 groot 2016-05-27 19:47:07 UTC 
rene@, right now kde@ is under-staffed, so we're in a process of starting-to-get-ports-mentored. Adding pi@, who has offered to commit things for those of us in the process.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-05-28 07:50:00 UTC 
A commit references this bug:

Author: pi
Date: Sat May 28 07:49:52 UTC 2016
New revision: 415976
URL: https://svnweb.freebsd.org/changeset/ports/415976

Log:
  devel/kdebindings4, devel/kdesdk4, misc/kdeedu4: re-add USE_KDE4

  In r415864, kdeprefix was removed from a whole lot of ports. In a
  few cases, USE_KDE4= was removed entirely. There are some combinations
  of OPTIONS that can cause build failures because KDE4_VERSION isn't
  defined. This fixes it.

  PR:		209799
  Submitted by:	groot@kde.org (kde)

Changes:
  head/devel/kdebindings4/Makefile
  head/devel/kdesdk4/Makefile
  head/misc/kdeedu4/Makefile
Comment 5 Kurt Jaeger freebsd_committer freebsd_triage 2016-05-28 07:50:16 UTC 
Committed, thanks!