Bug 210003 - net/pecl-geoip: Unbreak with PHP 7.0
Summary: net/pecl-geoip: Unbreak with PHP 7.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Many People
Assignee: Po-Chuan Hsieh
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-06-03 19:41 UTC by Hung-Yi Chen
Modified: 2016-10-02 15:23 UTC (History)
1 user (show)

See Also:
bugzilla: maintainer-feedback? (sunpoet)

Attachments
net_pecl-geoip.patch (10.66 KB, patch)
2016-06-03 19:41 UTC, Hung-Yi Chen 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hung-Yi Chen 2016-06-03 19:41:38 UTC 
Created attachment 170988 [details]
net_pecl-geoip.patch

* Make net/pecl-geoip can compile with PHP 7.0.
Comment 1 VK 2016-06-07 11:31:50 UTC 
Thanks for the patch. If I may suggest, it would be very helpful to submit patches against the svn tree (to have a patch that creates a patch) as that gives a better change context and makes resolving issues easier and faster.

Can you confirm this builds fine and passes tests? Are these fixes available or submitted upstream?

Cleaning up summary in favor of PR keywords.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-06-26 17:25:08 UTC 
A commit references this bug:

Author: sunpoet
Date: Sun Jun 26 17:24:17 UTC 2016
New revision: 417589
URL: https://svnweb.freebsd.org/changeset/ports/417589

Log:
  - Fix build with PHP 7.0

  PR:		210003
  Submitted by:	Hung-Yi Chen <gaod@hychen.org>

Changes:
  head/net/pecl-geoip/Makefile
  head/net/pecl-geoip/files/
  head/net/pecl-geoip/files/patch-geoip.c
  head/net/pecl-geoip/files/patch-php_geoip.h
Comment 3 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-10-02 15:23:53 UTC 
Proposed fix was committed, close.