Bug 210141 - Building sshd with WITHOUT_TCP_WRAPPERS=YES fails
Summary: Building sshd with WITHOUT_TCP_WRAPPERS=YES fails
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Many People
Assignee: Enji Cooper
URL: https://reviews.freebsd.org/D9049
Keywords:
: 210131 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-06-08 14:19 UTC by Sergey
Modified: 2020-02-14 17:06 UTC (History)
2 users (show)

See Also:
ngie: mfc-stable11+
ngie: mfc-stable10+
ngie: mfc-stable9-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey 2016-06-08 14:19:07 UTC 
Hello.
I have following setting in /etc/src.conf:
WITHOUT_TCP_WRAPPERS=YES 
nontheless building sshd fails complaining about absent tcpd.h file.
Regards.
Comment 1 Sergey 2016-06-08 14:19:40 UTC 
*** Bug 210131 has been marked as a duplicate of this bug. ***
Comment 2 Sergey 2017-01-05 09:02:29 UTC 
Please consider editing /usr/src/crypto/openssh/config.h file:

#define LIBWRAP 1

it's enable by default not checking WITHOUT_TCP_WRAPPERS=YES variable
Comment 3 Sergey 2017-01-05 15:20:51 UTC 
+

sed -E -i '' \
       -e '/^LIBADD=/ wrap//' \
/usr/src/secure/usr.sbin/sshd/Makefile
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-01-07 08:09:39 UTC 
A commit references this bug:

Author: ngie
Date: Sat Jan  7 08:08:36 UTC 2017
New revision: 311585
URL: https://svnweb.freebsd.org/changeset/base/311585

Log:
  Conditionalize building libwrap support into sshd

  Only build libwrap support into sshd if MK_TCP_WRAPPERS != no

  This will unbreak the build if libwrap has been removed from the system

  MFC after:	2 weeks
  PR:		210141
  Submitted by:	kpect@protonmail.com
  Differential Revision:	D9049

Changes:
  head/crypto/openssh/config.h
  head/secure/usr.sbin/sshd/Makefile
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-02-04 17:01:42 UTC 
A commit references this bug:

Author: ngie
Date: Sat Feb  4 17:00:48 UTC 2017
New revision: 313234
URL: https://svnweb.freebsd.org/changeset/base/313234

Log:
  MFC r311585:

  Conditionalize building libwrap support into sshd

  Only build libwrap support into sshd if MK_TCP_WRAPPERS != no

  This will unbreak the build if libwrap has been removed from the system

  PR:		210141

Changes:
_U  stable/10/
  stable/10/crypto/openssh/config.h
  stable/10/secure/usr.sbin/sshd/Makefile
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-02-04 17:27:17 UTC 
A commit references this bug:

Author: ngie
Date: Sat Feb  4 17:26:29 UTC 2017
New revision: 313243
URL: https://svnweb.freebsd.org/changeset/base/313243

Log:
  MFC r311585:

  Conditionalize building libwrap support into sshd

  Only build libwrap support into sshd if MK_TCP_WRAPPERS != no

  This will unbreak the build if libwrap has been removed from the system

  PR:		210141

Changes:
_U  stable/11/
  stable/11/crypto/openssh/config.h
  stable/11/secure/usr.sbin/sshd/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2020-02-14 17:06:37 UTC 
A commit references this bug:

Author: emaste
Date: Fri Feb 14 17:05:35 UTC 2020
New revision: 357922
URL: https://svnweb.freebsd.org/changeset/base/357922

Log:
  openssh: add a note about libwrap in config.h

  LIBWRAP is defined by the Makefile based on MK_TCP_WRAPPERS and should
  not be defined in config.h.

  PR:		210141
  Sponsored by:	The FreeBSD Foundation

Changes:
  head/crypto/openssh/FREEBSD-upgrade