Bug 210355 - if_ntb driver needs IFF_MULTICAST so IPv6 will work
Summary: if_ntb driver needs IFF_MULTICAST so IPv6 will work
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Eric van Gyzen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-06-17 19:46 UTC by David Bright
Modified: 2017-07-03 01:23 UTC (History)
3 users (show)

See Also:
ngie: mfc-stable11+
ngie: mfc-stable10+
ngie: mfc-stable9-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Bright freebsd_committer freebsd_triage 2016-06-17 19:46:40 UTC
When if_ntb sets up the interface, it does not set the IFF_MULTICAST flag. This prevents the interface from acquiring a link local address and, in fact, seems to make IPv6 pretty much non-functional.

Fix posted to Differential D6885.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-06-18 23:18:48 UTC
A commit references this bug:

Author: vangyzen
Date: Sat Jun 18 23:18:05 UTC 2016
New revision: 302014
URL: https://svnweb.freebsd.org/changeset/base/302014

Log:
  Fix if_ntb interface setup to include IFF_MULTICAST.

  This allows IPv6 link local addresses (and other IPv6 functionality) to work.

  PR:		210355
  Submitted by:	Steve Wahl and David Bright (both at Dell Inc.)
  Reviewed by:	cem, mav
  Tested by:	mav (on Intel hardware)
  Approved by:	re (kib)
  MFC after:	5 days
  Sponsored by:	Dell Inc.
  Differential Revision:	https://reviews.freebsd.org/D6885

Changes:
  head/sys/dev/ntb/if_ntb/if_ntb.c
Comment 2 David Bright freebsd_committer freebsd_triage 2017-07-02 23:16:56 UTC
Shouldn't this PR be closed?
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2017-07-03 01:21:45 UTC
(In reply to David Bright from comment #2)

The code wasn't MFCed.
Comment 4 Enji Cooper freebsd_committer freebsd_triage 2017-07-03 01:23:30 UTC
Ah, nevermind:

------------------------------------------------------------------------
r304375 | mav | 2016-08-18 03:23:51 -0700 (Thu, 18 Aug 2016) | 4 lines

MFC r302014: Fix if_ntb interface setup to include IFF_MULTICAST.

This allows IPv6 link local addresses (and other IPv6 functionality) to work.