Created attachment 171585 [details] patch https://docs.saltstack.com/en/latest/topics/releases/2016.3.1.html * updated port to new version * removed patches from _1 release
Created attachment 171586 [details] QA
Hi Christer, Can we have this upstream bug included in this update? https://github.com/saltstack/salt/issues/34094 I was going to submit a patch to fix 2016.3.0 but since you are going to update to 2016.3.1 would be better to have it in one try. Thanks!
(In reply to Andres Montalban from comment #2) Also seems this patch didn't get in to 2016.3.1 which was present on 2016.3.0-1: https://github.com/saltstack/salt/issues/33608 Maybe ohauer can help with that. Thanks!
Comment on attachment 171586 [details] QA Approval on build logs doesn't make much sense, removing. Also, unless something specific in the build log is required to be seen, it is generally enough to just confirm Poudriere passed, so we don't clutter the database with unnecessary files. Just a few hopefully helpful notes. Many thanks for doing this, of course! ;)
Summary clean up in favor of using attachment flags to show maintainer approval. ;)
A commit references this bug: Author: junovitch Date: Sun Jun 26 00:42:56 UTC 2016 New revision: 417508 URL: https://svnweb.freebsd.org/changeset/ports/417508 Log: sysutils/py-salt: update 2016.3.0 -> 2016.3.1 - Remove patches accepted upstream Changes: https://docs.saltstack.com/en/latest/topics/releases/2016.3.1.html PR: 210395 Submitted by: Christer Edwards <christer.edwards@gmail.com> (maintainer) Changes: head/sysutils/py-salt/Makefile head/sysutils/py-salt/distinfo head/sysutils/py-salt/files/patch-salt_grains_core.py head/sysutils/py-salt/files/patch-salt_grains_disks.py head/sysutils/py-salt/files/patch-salt_modules_pkgng.py head/sysutils/py-salt/files/patch-salt_returners_local__cache.py
Christer, did you have any issue approving the patches referenced by Andres in comment 2 and comment 3?
No issue.
A commit references this bug: Author: junovitch Date: Wed Jul 13 01:53:46 UTC 2016 New revision: 418455 URL: https://svnweb.freebsd.org/changeset/ports/418455 Log: sysutils/py-salt: add patches to handle runtime regressions in 2016.3.x Fixes cron.file from upstream issue #34094/#34095 [1]. This will be in 2016.3.2. - https://github.com/saltstack/salt/issues/34094 - https://github.com/saltstack/salt/pull/34095 Restore patch for upstream issue #33608. This was patched in 2016.3.0 but removed in the maintainer update to 2016.3.1 in r417508. However the patch has yet to be merged upstream. [2] - https://github.com/saltstack/salt/issues/33608 PR: 210627 [1], 210395 [2] Reported by: Andres Montalban <amontalban@gmail.com> Approved by: Christer Edwards <christer.edwards@gmail.com> (maintainer) MFH: 2016Q3 Changes: head/sysutils/py-salt/Makefile head/sysutils/py-salt/files/patch-salt_grains_core.py head/sysutils/py-salt/files/patch-salt_states_cron.py
A commit references this bug: Author: junovitch Date: Wed Jul 13 01:54:30 UTC 2016 New revision: 418456 URL: https://svnweb.freebsd.org/changeset/ports/418456 Log: MFH: r418455 sysutils/py-salt: add patches to handle runtime regressions in 2016.3.x Fixes cron.file from upstream issue #34094/#34095 [1]. This will be in 2016.3.2. - https://github.com/saltstack/salt/issues/34094 - https://github.com/saltstack/salt/pull/34095 Restore patch for upstream issue #33608. This was patched in 2016.3.0 but removed in the maintainer update to 2016.3.1 in r417508. However the patch has yet to be merged upstream. [2] - https://github.com/saltstack/salt/issues/33608 PR: 210627 [1], 210395 [2] Reported by: Andres Montalban <amontalban@gmail.com> Approved by: Christer Edwards <christer.edwards@gmail.com> (maintainer) Approved by: ports-secteam (with hat) Changes: _U branches/2016Q3/ branches/2016Q3/sysutils/py-salt/Makefile branches/2016Q3/sysutils/py-salt/files/patch-salt_grains_core.py branches/2016Q3/sysutils/py-salt/files/patch-salt_states_cron.py
(In reply to Christer Edwards from comment #8) Thanks! (In reply to Christer Edwards from comment #0) Created attachment 171585 [details] This patch removed the files/patch-salt_grains_core.py from https://github.com/saltstack/salt/issues/33608 that hasn't been merged upstream it. I SVN copied it from before the 2016.3.1 update and MFH'd that along with the cron.file fix requested in bug 210627 and comment 2.