Bug 210985 - [UPDATE] security/go.crypto
Summary: [UPDATE] security/go.crypto
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Julien Laffaye
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-07-10 19:37 UTC by Carlo Strub
Modified: 2016-07-26 18:12 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (jlaffaye)


Attachments
Patch (6.63 KB, patch)
2016-07-10 19:37 UTC, Carlo Strub
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlo Strub freebsd_committer freebsd_triage 2016-07-10 19:37:43 UTC
Update to latest version
Comment 1 Carlo Strub freebsd_committer freebsd_triage 2016-07-10 19:37:59 UTC
Created attachment 172353 [details]
Patch
Comment 2 Julien Laffaye freebsd_committer freebsd_triage 2016-07-17 19:46:06 UTC
It looks like go.net and go.crypto both needs each other...

===>  Building for go.net-20160708
http2/h2i/h2i.go:38:2: cannot find package "golang.org/x/crypto/ssh/terminal" in any of:
        /usr/local/go/src/golang.org/x/crypto/ssh/terminal (from $GOROOT)
        /usr/home/jlaffaye/head/net/go.net/work/src/golang.org/x/crypto/ssh/terminal (from $GOPATH)
        /usr/local/share/go/src/golang.org/x/crypto/ssh/terminal
*** Error code 1


and

===>  Building for go.crypto-20160709
acme/internal/acme/acme.go:25:2: cannot find package "golang.org/x/net/context" in any of:
        /usr/local/go/src/golang.org/x/net/context (from $GOROOT)
        /usr/home/jlaffaye/head/security/go.crypto/work/src/golang.org/x/net/context (from $GOPATH)
        /usr/local/share/go/src/golang.org/x/net/context
*** Error code 1


Maybe it was not such a good idea to put all the go pacages in one freebsd package ?
Comment 3 Carlo Strub freebsd_committer freebsd_triage 2016-07-25 21:31:03 UTC
Well. That is indeed unfortunate. Maybe we can drop the http2 and/or the acme support in either package. There are two big advantages over "go get"

1) signed sources
2) ease of use for people unfamiliar with go, for example when building "regular" binaries for chat programs, etc.

I think it is save for now to drop the circular dependencies by commenting them out in the Makefiles.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-07-26 16:48:44 UTC
A commit references this bug:

Author: jlaffaye
Date: Tue Jul 26 16:48:00 UTC 2016
New revision: 419129
URL: https://svnweb.freebsd.org/changeset/ports/419129

Log:
  - Update to 20160709 snapshot [1]
  - Remove acme target to avoid circular dependency with net/go.net
  - Add LICENSE

  PR:		210985
  Submitted by:	cs

Changes:
  head/security/go.crypto/Makefile
  head/security/go.crypto/distinfo
  head/security/go.crypto/pkg-plist
Comment 5 Julien Laffaye freebsd_committer freebsd_triage 2016-07-26 18:12:34 UTC
Commited with changes, thanks!