Bug 211187 - net/asterisk13: pjsip_cli: Uses invalid regular expression for show all
Summary: net/asterisk13: pjsip_cli: Uses invalid regular expression for show all
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Guido Falsi
URL: https://issues.asterisk.org/jira/brow...
Keywords: easy, needs-qa, patch
Depends on:
Blocks:
 
Reported: 2016-07-18 08:55 UTC by Dmitry Wagin
Modified: 2016-07-18 20:00 UTC (History)
0 users

See Also:
madpilot: maintainer-feedback+
madpilot: merge-quarterly+

Attachments
patch-res::res_pjsip::pjsip_cli.c (187 bytes, patch)
2016-07-18 08:55 UTC, Dmitry Wagin 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dmitry Wagin 2016-07-18 08:55:52 UTC 
Created attachment 172632 [details]
patch-res::res_pjsip::pjsip_cli.c

FreeBSD 'regexec' more selective in the parameters and an empty string as a regex parameter return an error.

On Linux all fine.
https://community.asterisk.org/t/pjsip-show-endpoints-no-objects-found/66994/15

Asterisk bug report
https://issues.asterisk.org/jira/browse/ASTERISK-26206
Comment 1 Guido Falsi freebsd_committer freebsd_triage 2016-07-18 16:52:44 UTC 
Thanks for pointing me to this asterisk bug report.

I'm going to add the patch to the ports tree, after testing, obviously.

I confirm this one is a good candidate for MFC to the quarterly branch.
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-07-18 18:02:04 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Jul 18 18:01:30 UTC 2016
New revision: 418726
URL: https://svnweb.freebsd.org/changeset/ports/418726

Log:
  FreeBSD's regexec() libc function is more restrictive than the linux
  one and will not accept an empty expression.

  Add patch (from PR) to fix this problem.

  PR:		211187
  Submitted by:	Dmitry Vagin <daemon.hammer at ya.ru>

Changes:
  head/net/asterisk13/Makefile
  head/net/asterisk13/files/patch-res_res__pjsip_pjsip__cli.c
Comment 3 Guido Falsi freebsd_committer freebsd_triage 2016-07-18 20:00:04 UTC 
Committed and merged. Thanks!
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-07-18 20:00:31 UTC 
A commit references this bug:

Author: madpilot
Date: Mon Jul 18 19:59:29 UTC 2016
New revision: 418740
URL: https://svnweb.freebsd.org/changeset/ports/418740

Log:
  MFH: r418726

  FreeBSD's regexec() libc function is more restrictive than the linux
  one and will not accept an empty expression.

  Add patch (from PR) to fix this problem.

  PR:		211187
  Submitted by:	Dmitry Vagin <daemon.hammer at ya.ru>

  Approved by:	ports-secteam (feld)

Changes:
_U  branches/2016Q3/
  branches/2016Q3/net/asterisk13/Makefile
  branches/2016Q3/net/asterisk13/files/patch-res_res__pjsip_pjsip__cli.c