Bug 211243 - Tools/scripts/bump-revision.sh: fixup last updates, and try to be better with slave ports
Summary: Tools/scripts/bump-revision.sh: fixup last updates, and try to be better with...
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Bartek Rutkowski
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-07-20 13:37 UTC by Mathieu Arnold
Modified: 2016-08-03 13:28 UTC (History)
2 users (show)

See Also:
mat: maintainer-feedback? (robak)


Attachments
patch (2.48 KB, patch)
2016-07-20 13:37 UTC, Mathieu Arnold
mat: maintainer-approval? (robak)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2016-07-20 13:37:57 UTC
Created attachment 172748 [details]
patch

the case $? needs to have the exit status of the grep, not the awk line, so remove the awk line, it was not really helpful anyway.

Also, with slave ports, most of the time, they don't have (PORT|DIST)VERSION,  try to use CATEGORIES, PKGNAMEPREFIX or PKGNAMESUFFIX.
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-08-03 13:28:49 UTC
A commit references this bug:

Author: mat
Date: Wed Aug  3 13:27:47 UTC 2016
New revision: 419519
URL: https://svnweb.freebsd.org/changeset/ports/419519

Log:
  fixup last updates, and try to be better with slave ports.

  the case $? needs to have the exit status of the grep, not the awk line,
  so remove the awk line, it was not really helpful anyway.

  Also, with slave ports, most of the time, they don't have
  (PORT|DIST)VERSION,  try to use CATEGORIES, PKGNAMEPREFIX or
  PKGNAMESUFFIX.

  PR:		211243
  Submitted by:	mat
  Approved by:	maintainer timeout
  Sponsored by:	Absolight

Changes:
  head/Tools/scripts/bump-revision.sh