Bug 211955 - textproc/zsh-syntax-highlighting maintainer: upgrade to version 20160816
Summary: textproc/zsh-syntax-highlighting maintainer: upgrade to version 20160816
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-08-18 00:04 UTC by Joseph Mingrone
Modified: 2016-08-19 11:49 UTC (History)
0 users

See Also:

Attachments
svn diff to upgrade textproc/zsh-syntax-highlighting to 20160816 (1.43 KB, patch)
2016-08-18 00:04 UTC, Joseph Mingrone 		jrm: maintainer-approval+
Details | Diff
new svn diff reflecting amdmi3's recommendations (1.17 KB, patch)
2016-08-18 14:18 UTC, Joseph Mingrone 		jrm: maintainer-approval+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Mingrone freebsd_committer freebsd_triage 2016-08-18 00:04:08 UTC 
Created attachment 173806 [details]
svn diff to upgrade textproc/zsh-syntax-highlighting to 20160816

portlint: OK
testport: OK (poudriere: 10.3-RELEASE-p5, amd64, default options) [1]

While here
- add DOCS option
- patch upstream Makefile so that port defined locations are respected
- add NO_BUILD=yes.

[1] http://pkg.awarnach.mathstat.dal.ca/data/10amd64-default/2016-08-17_20h54m23s/logs/zsh-syntax-highlighting-20160816.log
Comment 1 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-18 09:49:16 UTC 
You don't seem to need MAKE_ENV and makefile patcing. Upstream Makefile already uses ?= so it respects values passed through environment, so you could just pass SHARE_DIR and DOC_DIR (PREFIX is always passed by the framework), but since they are already equal to our DATADIR and DOCSDIR values, no extra actions are needed at all. I suggest to commit this without MAKE_ENV and post-patch bits.
Comment 2 Joseph Mingrone freebsd_committer freebsd_triage 2016-08-18 12:14:15 UTC 
Should we be concerned when the defaults for DATADIR and DOCSDIR are overridden?  In those cases, upstream's SHARE_DIR and DOC_DIR won't be correct.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2016-08-18 14:04:01 UTC 
(In reply to Joseph Mingrone from comment #2)

> Should we be concerned when the defaults for DATADIR and DOCSDIR are
> overridden?  In those cases, upstream's SHARE_DIR and DOC_DIR won't be
> correct.

No, DATADIR and DOCSDIR are not supposed to be set by the user.
Comment 4 Joseph Mingrone freebsd_committer freebsd_triage 2016-08-18 14:18:35 UTC 
Created attachment 173824 [details]
new svn diff reflecting amdmi3's recommendations

- remove unnecessary post-patch parts
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-08-19 11:49:20 UTC 
A commit references this bug:

Author: amdmi3
Date: Fri Aug 19 11:49:10 UTC 2016
New revision: 420459
URL: https://svnweb.freebsd.org/changeset/ports/420459

Log:
  - Update to 20160816
  - Add NO_BUILD
  - Optionize DOCS

  PR:		211955
  Submitted by:	jrm@ftfl.ca (maintainer)

Changes:
  head/textproc/zsh-syntax-highlighting/Makefile
  head/textproc/zsh-syntax-highlighting/distinfo