Bug 212362 - devel/opencl: Update to API 2.1
Summary: devel/opencl: Update to API 2.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Koop Mast
URL:
Keywords: needs-qa, patch
: 206779 (view as bug list)
Depends on:
Blocks: 212363
  Show dependency treegraph
 
Reported: 2016-09-04 07:28 UTC by O. Hartmann
Modified: 2020-03-20 13:22 UTC (History)
3 users (show)

See Also:
koobs: maintainer-feedback? (ohartmann)


Attachments
opencl-2.1.diff (5.83 KB, patch)
2016-09-04 07:28 UTC, O. Hartmann
no flags Details | Diff
OpenCL 2.1 API Patch: cl.h changed upstream, adjust distinfo checksum (5.83 KB, patch)
2016-09-10 16:57 UTC, O. Hartmann
no flags Details | Diff
opencl 2.1 update using github macro (4.35 KB, patch)
2016-09-13 15:39 UTC, Koop Mast
no flags Details | Diff
opencl 2.1 patch with cl.hpp updated (4.06 KB, patch)
2016-10-04 23:35 UTC, Steve Wills
no flags Details | Diff
opencl 2.1 patch with cl.hpp updated and plist (4.66 KB, patch)
2016-10-05 00:03 UTC, Steve Wills
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description O. Hartmann 2016-09-04 07:28:18 UTC
Created attachment 174359 [details]
opencl-2.1.diff

The Khronos group has already published new headers to meet OpenCL API 2.1.

Atteched, you'll find a svn diff according to the new API and a new file.

Some changes were needed:

The header cl2.hpp is located at another site/master_site, so the MASTER_SITES has to be adjusted as well the sources for the files downloaded for installation, see diff.
Comment 1 Kubilay Kocak freebsd_committer freebsd_triage 2016-09-08 09:23:28 UTC
Please confirm this change passes QA (poudriere, portlint, etc) and dont forget to set maintainer-approval to + on attachments for ports you are maintainer of.

While I'm here, clean up summary
Comment 2 O. Hartmann 2016-09-10 16:57:14 UTC
Created attachment 174623 [details]
OpenCL 2.1 API Patch: cl.h changed upstream, adjust distinfo checksum

Upstream made slight changes to cl.h, so its chesum doesn't match anymore. The patch adjusts distinfo.
Comment 3 O. Hartmann 2016-09-10 17:01:10 UTC
*** Bug 206779 has been marked as a duplicate of this bug. ***
Comment 4 O. Hartmann 2016-09-10 17:07:39 UTC
(In reply to Kubilay Kocak from comment #1)
In my poudriere environment, the updated port (including new patch for distinfo) built well.
Comment 5 Koop Mast freebsd_committer freebsd_triage 2016-09-13 15:39:40 UTC
Created attachment 174731 [details]
opencl 2.1 update using github macro

Grab bug.

Use the github macro's. so we can drop a lot of complex code, we also don't have to download every file alone and worry about checksum conflicts.

I'm not a fan of 4+ files in PLIST_FILES so move to a plist.
Comment 6 Steve Wills freebsd_committer freebsd_triage 2016-10-04 23:35:42 UTC
Created attachment 175429 [details]
opencl 2.1 patch with cl.hpp updated

I think the previous patch lost cl.hpp. This patch includes that and cl2.hpp as well.
Comment 7 Steve Wills freebsd_committer freebsd_triage 2016-10-05 00:03:34 UTC
Created attachment 175432 [details]
opencl 2.1 patch with cl.hpp updated and plist

Sorry, that patch missed the plist change, this one has it.
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-10-22 11:24:38 UTC
A commit references this bug:

Author: kwm
Date: Sat Oct 22 11:24:21 UTC 2016
New revision: 424465
URL: https://svnweb.freebsd.org/changeset/ports/424465

Log:
  Update opencl (headers) to 2.1.

  * Use github macro's for fetching sources instead of manualy fetching.
  * Switch to a pkg-plist

  PR:		212362
  Submitted by:	maintainer (original patch),
  		kwm@ and swills@ (updated versions)
  Approved by:	maintainer timeout (for updated versions)

Changes:
  head/devel/opencl/Makefile
  head/devel/opencl/distinfo
  head/devel/opencl/pkg-descr
  head/devel/opencl/pkg-plist
Comment 9 Koop Mast freebsd_committer freebsd_triage 2016-10-22 11:29:14 UTC
Committed thanks!

I did change the GH_TAGNAME, this is because it failed to fetch during pre commit poudriere testing. Turns out the old GH_TAGNAME might point to a branch but new stuff might be added there so it not stable. So I added a git commit hash for the headers github repo and a propper tag for the hpp github repo to pin it in place.
Comment 10 commit-hook freebsd_committer freebsd_triage 2020-03-20 13:22:27 UTC
A commit references this bug:

Author: db
Date: Fri Mar 20 13:21:43 UTC 2020
New revision: 528777
URL: https://svnweb.freebsd.org/changeset/ports/528777

Log:
  reated attachment 212362 [details]
  Fix emulators/qemu-sbruno build with lld 10.0.0

  As reported in bug 244251, with clang and lld 10.0.0 the emulators/qemu-sbruno port fails in the configure stage:

  ===>  Configuring for qemu-user-static-2.11.50.g20191211_3

  ERROR: We need to link the QEMU user mode binaries at a
         specific text address. Unfortunately your linker
         doesn't support either the -Ttext-segment option or
         printing the default linker script with --verbose.
         If you don't want the user mode binaries, pass the
         --disable-user option to configure.

  ===>  Script "configure" failed unexpectedly.
  Please report the problem to emulation@FreeBSD.org [maintainer] and attach
  the
  "/wrkdirs/usr/ports/emulators/qemu-user-static/work/qemu-bsd-user-d587db6/config.log"
  including the output of the failure of your make command. Also, it might be
  a good idea to provide an overview of all packages installed on your system
  (e.g. a /usr/local/sbin/pkg-static info -g -Ea).
  *** Error code 1

  This is because lld 10.0.0 no longer supports the -Ttext-segment option, and uses --image-base for similar functionality.

  I am proposing a patch that makes the configure script check for the --image-base option first, then the -Ttext-segment option.

  PR:		ports/212362
  Submitted by:	dim@FreeBSD.org
  Approved by:	Maintainer

Changes:
  head/emulators/qemu-sbruno/files/patch-configure