Bug 212382 - [PATCH] deskutils/fbreader: installation fails with GTK2 UI
Summary: [PATCH] deskutils/fbreader: installation fails with GTK2 UI
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dmitry Marakasov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2016-09-05 08:08 UTC by Maciej Pasternacki
Modified: 2016-09-07 13:24 UTC (History)
0 users

See Also:
amdmi3: merge-quarterly+

Attachments
fbreader-fix-plist-for-gtk2.patch (458 bytes, patch)
2016-09-05 08:08 UTC, Maciej Pasternacki 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pasternacki 2016-09-05 08:08:21 UTC 
Created attachment 174380 [details]
fbreader-fix-plist-for-gtk2.patch

One of the pkg-plist files used by QT4 UI is not tagged as such. It is missing when GTK2 UI is selected, and installation fails. Trivial patch adds the missing tag.
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2016-09-05 08:08:21 UTC 
Maintainer informed via mail
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-09-07 13:22:51 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Sep  7 13:21:48 UTC 2016
New revision: 421500
URL: https://svnweb.freebsd.org/changeset/ports/421500

Log:
  - Fix plist for GTK2 mode
  - Switch to USES=localbase

  PR:		212382
  Submitted by:	maciej@pasternacki.net
  Approved by:	just fix it blanket
  MFH:		2016Q3 (blanket)

Changes:
  head/deskutils/fbreader/Makefile
  head/deskutils/fbreader/pkg-plist
Comment 3 commit-hook freebsd_committer freebsd_triage 2016-09-07 13:23:52 UTC 
A commit references this bug:

Author: amdmi3
Date: Wed Sep  7 13:23:04 UTC 2016
New revision: 421501
URL: https://svnweb.freebsd.org/changeset/ports/421501

Log:
  MFH: r421500

  - Fix plist for GTK2 mode
  - Switch to USES=localbase

  PR:		212382
  Submitted by:	maciej@pasternacki.net
  Approved by:	just fix it blanket
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2016Q3/
  branches/2016Q3/deskutils/fbreader/Makefile
  branches/2016Q3/deskutils/fbreader/pkg-plist
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2016-09-07 13:24:01 UTC 
The fix is not quite correct, keynames-gtk2.xml is missing from plist. Fixed that, tested, committe under blanket and merged into quaterly branch.