Bug 212395 - databases/sqlitebrowser: Update to 3.9.0
Summary: databases/sqlitebrowser: Update to 3.9.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Ruslan Makhmatkhanov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-05 21:22 UTC by Loïc Bartoletti
Modified: 2016-10-01 01:19 UTC (History)
2 users (show)

See Also:
lbartoletti: maintainer-feedback+

Attachments
Single options port (4.31 KB, patch)
2016-09-05 21:22 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
New port sqlitebrowser-qt5 (5.50 KB, patch)
2016-09-05 21:23 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
New diff after sqlitebrowser-qt5 added (4.40 KB, patch)
2016-09-20 19:14 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
remove INSTALL_ICONS (4.38 KB, patch)
2016-09-20 20:36 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
Fix patch (DATADIR) for sqlitebrowser-3.9.0 (5.02 KB, patch)
2016-09-25 12:37 UTC, Loïc Bartoletti 		lbartoletti: maintainer-approval+
Details | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-05 21:22:44 UTC 
Created attachment 174396 [details]
Single options port

Update to 3.9.0
Add options to use Qt5 or Qt4.

For submitter, I have made two patch:

- First, using single option for Qt5/Qt5
- Second, creating a port sqlitebrowser-qt5 which conflicts sqlitebrowser (Qt4)

I don't know which is the best practice.

Portlint OK
Poudriere 10, 11, 12 amd64 and i386 OK
Comment 1 Bugzilla Automation freebsd_committer freebsd_triage 2016-09-05 21:22:44 UTC 
Maintainer informed via mail
Comment 2 Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-05 21:23:14 UTC 
Created attachment 174397 [details]
New port sqlitebrowser-qt5
Comment 3 Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-20 19:14:47 UTC 
Created attachment 175015 [details]
New diff after sqlitebrowser-qt5 added

New diff port since sqlitebrowser-qt5 is committed https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211217
Comment 4 Tobias C. Berner freebsd_committer freebsd_triage 2016-09-20 19:22:22 UTC 
Hi

* Are you sure, you wanted to replace '%%DATADIR%%' in the patches with its expansion?
* INSTALLS_ICONS is not needed, as this is not a gtk+ application.


mfg Tobias
Comment 5 Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-20 20:35:34 UTC 
(In reply to Tobias C. Berner from comment #4)
OK. I misunderstand the porlint's warning for INSTALL_ICONS. I remove it.
For DATADIR, yes it's patch needed for a correct FreeBSD install.
Comment 6 Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-20 20:36:02 UTC 
Created attachment 175018 [details]
remove INSTALL_ICONS
Comment 7 Loïc Bartoletti freebsd_committer freebsd_triage 2016-09-25 12:37:53 UTC 
Created attachment 175156 [details]
Fix patch (DATADIR) for sqlitebrowser-3.9.0
Comment 8 commit-hook freebsd_committer freebsd_triage 2016-10-01 01:06:18 UTC 
A commit references this bug:

Author: rm
Date: Sat Oct  1 01:05:15 UTC 2016
New revision: 423030
URL: https://svnweb.freebsd.org/changeset/ports/423030

Log:
  databases/sqlitebrowser: update to 3.9.0

  - update to 3.9.0
  - update maintainer's email
  - pet portlint

  PR:		212395
  Submitted by:	 lbartoletti <lbartoletti@tuxfamily.org> (maintainer)

Changes:
  head/databases/sqlitebrowser/Makefile
  head/databases/sqlitebrowser/distinfo
  head/databases/sqlitebrowser/files/patch-CMakeLists.txt
  head/databases/sqlitebrowser/files/patch-src-Application.cpp
  head/databases/sqlitebrowser/files/patch-src-PreferencesDialog.cpp
Comment 9 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-10-01 01:16:19 UTC 
Committed with couple of changes:
1. USE_QT5 components were not changed, because poudriere build showed no evidence that these dependencies are needed anywhere behind build phase. 
2. Port name was trimmed from COMMENT
Comment 10 Ruslan Makhmatkhanov freebsd_committer freebsd_triage 2016-10-01 01:19:26 UTC 
Hmm, I can oath that Assignee field was filled with freebsd-ports-bugs@.
Apologies, Tobias.