Created attachment 174497 [details] shell archive of new net-mgmt/prometheus port Port rookie here, any feedback or recommendations will be received graciously.
Created attachment 174498 [details] /usr/ports/UIDs patch for new user called prometheus
Created attachment 174499 [details] /usr/ports/GIDs patch for new user called prometheus
Hi Jev, thanks for giving porting a go :) The best and most comprehensive way to QA ports prior to submission and review is outlined here: https://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/testing.html In particular and in summary: - poudriere - portlint - /etc/make.conf -> DEVELOPER=yes Most major issues will be identified through those processes. Also, unified diffs are acceptable for new ports. In the new port case, this also precludes the need for multiple attachments. Accordingly, feel free to replace the 3 attachments here with a single unified diff (preferably `svn diff`) that includes all of: - the port files - the addition of the port to category/Makefile [1] - UID/GID file additions [1] See: https://www.freebsd.org/doc/en/articles/committers-guide/ports.html#ports-qa-adding If you need further help or have questions, you can also join #freebsd-ports on freenode Have fun!
Created attachment 175078 [details] svn diff patch This port still fails on `port test`. Attaching the latest version anyway. I have asked for some help on the mailing lists here; https://lists.freebsd.org/pipermail/freebsd-ports/2016-September/104922.html
Created attachment 175101 [details] Update prometheus patch Passes `poudriere testport`. I think this is good to be committed. :)
Created attachment 175767 [details] new patch for latest prometheus release 1.2.1 Passes poudriere testport on 11.0-RELEASE
Passes `poudriere testport` on: 11.0-RELEASE-p1 10.3-RELEASE-p10 9.3-RELEASE
testbuilds@work. Please note that the Makefile and distinfo of that patch still say 1.1.3. I've updated the version number to 1.2.1 and ran make makesum to really use 1.2.1 8-}
testbuilds OK
A commit references this bug: Author: pi Date: Sat Oct 15 05:09:12 UTC 2016 New revision: 424001 URL: https://svnweb.freebsd.org/changeset/ports/424001 Log: New port: net-mgmt/prometheus Prometheus is a systems and service monitoring system. It collects metrics from configured targets at given intervals, evaluates rule expressions, displays the results, and can trigger alerts if some condition is observed to be true. Prometheus' main distinguishing features as compared to other monitoring systems are: - a multi-dimensional data model (timeseries defined by metric name and set of key/value dimensions) - a flexible query language to leverage this dimensionality - no dependency on distributed storage; single server nodes are autonomous - timeseries collection happens via a pull model over HTTP - pushing timeseries is supported via an intermediary gateway - targets are discovered via service discovery or static configuration - multiple modes of graphing and dashboarding support - support for hierarchical and horizontal federation WWW: https://prometheus.io/ PR: 212468 Submitted by: Jev Bjoersell <jev@ecadlabs.com> Changes: head/GIDs head/UIDs head/net-mgmt/Makefile head/net-mgmt/prometheus/ head/net-mgmt/prometheus/Makefile head/net-mgmt/prometheus/distinfo head/net-mgmt/prometheus/files/ head/net-mgmt/prometheus/files/prometheus.in head/net-mgmt/prometheus/pkg-descr
Committed, thanks!
Thank you Kurt! I realize I attached a stale patch, hence you saw the 1.1.3 references. Lesson learned for me, I will be more careful next time.
Please note that an issue existed for this port in bug 210059
Not sure how I missed it myself :|