Bug 212486 - Change how addport gets variables from the Makefile.
Summary: Change how addport gets variables from the Makefile.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Ports Framework (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Mathieu Arnold
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-08 12:23 UTC by Mathieu Arnold
Modified: 2016-09-08 12:49 UTC (History)
1 user (show)

See Also:
crees: maintainer-feedback+

Attachments
v1 (960 bytes, patch)
2016-09-08 12:23 UTC, Mathieu Arnold 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Arnold freebsd_committer freebsd_triage 2016-09-08 12:23:05 UTC 
Created attachment 174527 [details]
v1
Comment 1 Chris Rees freebsd_committer freebsd_triage 2016-09-08 12:44:15 UTC 
I suppose this mainly helps when DISTVERSION and slave ports are used.

Please go ahead.

Chris
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-09-08 12:49:50 UTC 
A commit references this bug:

Author: mat
Date: Thu Sep  8 12:49:03 UTC 2016
New revision: 421545
URL: https://svnweb.freebsd.org/changeset/ports/421545

Log:
  Use make(1) to extract variables from a Makefile, not grep.

  PR:		212486
  Submitted by:	mat
  Approved by:	crees (maintainer)
  Sponsored by:	Absolight

Changes:
  head/Tools/scripts/addport