Bug 213087 - shells/fish: Installing without NLS broken.
Summary: shells/fish: Installing without NLS broken.
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: John Marino
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-09-29 14:57 UTC by eborisch+FreeBSD
Modified: 2016-09-30 13:41 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (freebsd.users)

Attachments
svn-diff_pkg-plist (926 bytes, patch)
2016-09-29 16:15 UTC, Walter Schwarzenfeld 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description eborisch+FreeBSD 2016-09-29 14:57:36 UTC 
Problem: Fish won't install without NLS option.

Cause:
The pkg-plist does not flag the NLS-only files with %%NLS%%.

Fix: s^(.*LC_MESSAGES.*)^%%NLS%%\1^ in pkg-plist.
Comment 1 Walter Schwarzenfeld freebsd_triage 2016-09-29 16:15:34 UTC 
Created attachment 175275 [details]
svn-diff_pkg-plist
Comment 2 Walter Schwarzenfeld freebsd_triage 2016-09-29 16:17:07 UTC 
Testbuilds 10.3-amd64 und 9.3-amd64 ok.
Comment 3 Walter Schwarzenfeld freebsd_triage 2016-09-29 17:50:35 UTC 
Testbuilds with poudriere 10.3-i386 and 93-i386 also ok.
Comment 4 John Marino freebsd_committer freebsd_triage 2016-09-30 13:36:48 UTC 
I've confirmed the problem and the fix.  We don't need to wait for maintainer approval on this one.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-09-30 13:41:11 UTC 
A commit references this bug:

Author: marino
Date: Fri Sep 30 13:40:13 UTC 2016
New revision: 422984
URL: https://svnweb.freebsd.org/changeset/ports/422984

Log:
  shells/fish: Fix plist when NLS option off

  PR:		213087
  Reported by:	eborisch (gmail)
  Patch by:	w.schwarzenfeld (utanet.at)
  confirmed by:	marino
  Approved by:	just-fix-it

Changes:
  head/shells/fish/Makefile
  head/shells/fish/pkg-plist
Comment 6 John Marino freebsd_committer freebsd_triage 2016-09-30 13:41:42 UTC 
Thanks for report and patch!