Bug 213284 - textproc/librevenge: request to have separate DOXYGEN option
Summary: textproc/librevenge: request to have separate DOXYGEN option
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: FreeBSD Office Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-07 19:42 UTC by John Marino
Modified: 2016-10-19 23:21 UTC (History)
1 user (show)

See Also:
truckman: maintainer-feedback+


Attachments
patch to change DOCS to DOXYGEN (645 bytes, patch)
2016-10-19 18:20 UTC, John Marino
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Marino freebsd_committer freebsd_triage 2016-10-07 19:42:46 UTC
It seems that there is a trend to split doxygen out of DOCS options.  Several ports have already been converted.

Can we get librevenge to change DOCS to DOXYGEN and have it off by default?
Comment 1 John Marino freebsd_committer freebsd_triage 2016-10-19 18:20:55 UTC
Created attachment 175941 [details]
patch to change DOCS to DOXYGEN

Here's a patch that does what I requested 2 weeks ago.  Can somebody on the openoffice team please approve?  It's trivial.
Comment 2 John Marino freebsd_committer freebsd_triage 2016-10-19 18:22:08 UTC
I guess technically it requires a PORTREVISION revbump although poudriere would just rebuild it when it sees the options change.
Comment 3 Don Lewis freebsd_committer freebsd_triage 2016-10-19 21:57:12 UTC
Approved.

Yes, I think a PORTREVISION bump is necessary because the contents of +MANIFEST in the package are affected.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-10-19 23:20:36 UTC
A commit references this bug:

Author: marino
Date: Wed Oct 19 23:20:18 UTC 2016
New revision: 424295
URL: https://svnweb.freebsd.org/changeset/ports/424295

Log:
  textproc/librevenge: change DOCS option to DOXYGEN

  Follow trend to move optional doxygen documentation generation away from
  DOCS option to its own dedication option.

  PR:		213284
  Approved by:	office (truckman)

Changes:
  head/textproc/librevenge/Makefile
Comment 5 John Marino freebsd_committer freebsd_triage 2016-10-19 23:21:18 UTC
Thanks Don!