Bug 214189 - emulators/vice: fails to build with ffmpeg 3.x
Summary: emulators/vice: fails to build with ffmpeg 3.x
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Dirk Meyer
URL:
Keywords:
Depends on:
Blocks: 207547
  Show dependency tree / graph
 
Reported: 2016-11-04 04:43 UTC by Jan Beich
Modified: 2016-11-14 13:12 UTC (History)
0 users

See Also:
dinoex: maintainer-feedback+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-11-04 04:43:47 UTC 
ffmpegdrv.c:206:27: error: use of undeclared identifier 'CODEC_ID_MPEG4'; did you mean 'AV_CODEC_ID_MPEG4'?
    { "FFMPEGVideoCodec", CODEC_ID_MPEG4, RES_EVENT_NO, NULL,
                          ^~~~~~~~~~~~~~
                          AV_CODEC_ID_MPEG4
/usr/local/include/libavcodec/avcodec.h:207:5: note: 'AV_CODEC_ID_MPEG4' declared here
    AV_CODEC_ID_MPEG4,
    ^
ffmpegdrv.c:590:23: error: use of undeclared identifier 'PIX_FMT_RGB24'; did you mean 'AV_PIX_FMT_RGB24'?
    if (c->pix_fmt != PIX_FMT_RGB24) {
                      ^~~~~~~~~~~~~
                      AV_PIX_FMT_RGB24
/usr/local/include/libavutil/pixfmt.h:64:5: note: 'AV_PIX_FMT_RGB24' declared here
    AV_PIX_FMT_RGB24,     ///< packed RGB 8:8:8, 24bpp, RGBRGB...
    ^

http://package23.nyi.freebsd.org/data/103i386-default-PR207547/2016-10-04_18h24m30s/logs/errors/vice-gnome-2.4_7.log
Comment 1 commit-hook freebsd_committer freebsd_triage 2016-11-06 17:39:27 UTC 
A commit references this bug:

Author: dinoex
Date: Sun Nov  6 17:39:21 UTC 2016
New revision: 425573
URL: https://svnweb.freebsd.org/changeset/ports/425573

Log:
  - use new ffmpeg ids
  PR:		214189

Changes:
  head/emulators/vice/Makefile
Comment 2 Dirk Meyer freebsd_committer freebsd_triage 2016-11-06 17:41:04 UTC 
Please test again for ffmpeg3
Comment 3 Jan Beich freebsd_committer freebsd_triage 2016-11-06 22:30:02 UTC 
It also needs PixelFormat -> AVPixelFormat.

  ffmpegdrv.c:592:41: error: argument type 'enum PixelFormat' is incomplete
              (video_width, video_height, AV_PIX_FMT_RGB24,
                                        ^~~~~~~~~~~~~~~~
Comment 4 Jan Beich freebsd_committer freebsd_triage 2016-11-09 07:45:04 UTC 
See comment 3.
Comment 5 commit-hook freebsd_committer freebsd_triage 2016-11-14 06:49:16 UTC 
A commit references this bug:

Author: dinoex
Date: Mon Nov 14 06:48:25 UTC 2016
New revision: 426087
URL: https://svnweb.freebsd.org/changeset/ports/426087

Log:
  - fix build with ffmpeg3
  PR:		214189

Changes:
  head/emulators/vice/Makefile
Comment 6 Jan Beich freebsd_committer freebsd_triage 2016-11-14 13:12:02 UTC 
I confirm, it builds fine with ffmpeg 3.2 now.