Created attachment 177311 [details]
new/sabnzbdplus patch

Created attachment 177312 [details]
sabnzbdplus patch

Created attachment 177313 [details]
sabnzbdplus patch

Comment 4 Kubilay Kocak 2016-11-23 07:13:20 UTC

Could the localizations be made OPTION'al (and OPTIONS_DEFAULT), rather than unconditionally removed? 

Users may already rely on / use them. Feature removal should be considered carefully.

I only removed files that did not exist in the release posted on github.

Comment 6 Kubilay Kocak 2016-11-23 07:22:27 UTC

@Josh Perhaps they need to be built (processed) when using the repository sources. Can you look into it please. It may require some build/config parameter.

Comment 7 Kubilay Kocak 2016-11-23 07:24:04 UTC

I see the *.mo files are included in the release tarballs linked via the homepage [1]

https://github.com/sabnzbd/sabnzbd/releases/tag/1.1.1

Comment 8 Kubilay Kocak 2016-11-23 07:25:13 UTC

The process mentioned to compile the translations is:

https://github.com/sabnzbd/sabnzbd/blob/develop/INSTALL.txt#L94

Comment 9 Kubilay Kocak 2016-11-23 07:26:08 UTC

In the meantime, one may want to grab the DISTFILES from the GitHub /releases/ URL which contains the pre-compiled files

Ahh, ok. I'll try grabbing the tarball being linked to then.

Any idea how I could grab this link?
https://github.com/sabnzbd/sabnzbd/releases/download/1.1.1/SABnzbd-1.1.1-src.tar.gz

Actually as you linked we could just create the 'mo' files. I'll try that when I get a chance.

Created attachment 177900 [details]
sabnzbdplus patch

Ok I gave up on trying to produce our own language files for the time being. You can see my attempts here.
https://forums.sabnzbd.org/viewtopic.php?f=1&t=21820

Instead I took the easier route and just adjusted the URL for github instead of sourceforge.

Comment 14 Dmitry Marakasov 2016-12-29 09:52:21 UTC

Please use USE_GITHUB.

(In reply to Dmitry Marakasov from comment #14)

I tried USE_GITHUB, but then it will grab the source from the repo directly instead of the released version named "SABnzbd-VERSION-src".
In this case the language (.mo) files are not included. I tried building these but was having issues as discussed here.
https://forums.sabnzbd.org/viewtopic.php?f=1&t=21820#p109327

If someone can figure out how to build these then USE_GITHUB would be a good option. I gave up after trying for a few days.

Comment 16 Dmitry Marakasov 2016-12-29 16:52:18 UTC

(In reply to joshruehlig from comment #15)
> (In reply to Dmitry Marakasov from comment #14)
> 
> I tried USE_GITHUB, but then it will grab the source from the repo directly
> instead of the released version named "SABnzbd-VERSION-src".
> In this case the language (.mo) files are not included. I tried building
> these but was having issues as discussed here.
> https://forums.sabnzbd.org/viewtopic.php?f=1&t=21820#p109327
> 
> If someone can figure out how to build these then USE_GITHUB would be a good
> option. I gave up after trying for a few days.

Oh, sorry, I've missed you're fetching file from release and not the source snapshot. This way you just don't need GH_ACCOUNT/GH_PROJECT.

understood the variables dont need to be defined that way. I'm fine either way removing them, or keeping them. I just thought it might be a bit more clear we are getting files from github, even though we actually aren't using the github function.

Created attachment 178654 [details]
sabnzbdplus patch

Created attachment 178655 [details]
sabnzbdplus patch

Thanks to help from nahun on the SABnzbd forum I was able to build the locale files.
See https://forums.sabnzbd.org/viewtopic.php?f=1&t=21820#p109916

The patch has been updated and is ready for review.

For what its worth I've tested the patch and everything works as expected including the translations.

Created attachment 179204 [details]
sabnzbdplus patch

I updated the diff for sabnzbd v1.2.0. py27-openssl is no longer needed, and instead py27-cryptography is used for SSL.

Comment 23 Dmitry Marakasov 2017-01-23 17:12:49 UTC

(In reply to joshruehlig from comment #22)
> Created attachment 179204 [details]
> sabnzbdplus patch
> 
> I updated the diff for sabnzbd v1.2.0. py27-openssl is no longer needed, and
> instead py27-cryptography is used for SSL.

Please test the port with poudriere before submission.

===>  Patching for sabnzbdplus-1.2.0
===>  Applying FreeBSD patches for sabnzbdplus-1.2.0
cd /wrkdirs/usr/ports/news/sabnzbdplus/work/sabnzbd-1.2.0 && /usr/local/bin/python2.7 tools/make_mo.py
/bin/sh: /usr/local/bin/python2.7: not found
*** Error code 127

Stop.
make: stopped in /usr/ports/news/sabnzbdplus
build of news/sabnzbdplus ended at Mon Jan 23 19:50:28 MSK 2017
build time: 00:00:01

Probably you should call locale generation from where it belongs, and that is not patch stage.

(In reply to Dmitry Marakasov from comment #23)
Ok, never used poudriere before. I can try installing that before I post for you review.

Is the best place to generate the locale files 'do-build'? I assume I would also need to remove the NO_BUILD option.

Comment 25 Dmitry Marakasov 2017-01-24 12:14:49 UTC

(In reply to joshruehlig from comment #24)

> Ok, never used poudriere before. I can try installing that before I post for
> you review.
> 
> Is the best place to generate the locale files 'do-build'? I assume I would
> also need to remove the NO_BUILD option.

Yes

Created attachment 179414 [details]
sabnzbdplus patch

I have yet to test this with poudriere. This diff moves the locale generation to do-build and removed a comment that does not seem relevant.

Comment 27 Dmitry Marakasov 2017-01-30 10:23:07 UTC

Committed, thank you! It built find, but I've moved USE_GITHUB below DEPENDS section where it belongs (see portlint output). Next time, please check your submissions with poudriere and portlint.

Comment 28 commit-hook 2017-01-30 10:23:23 UTC

A commit references this bug:

Author: amdmi3
Date: Mon Jan 30 10:22:18 UTC 2017
New revision: 432827
URL: https://svnweb.freebsd.org/changeset/ports/432827

Log:
  - Update to 1.1.1
  - Switch to new GitHub home

  PR:		214768
  Submitted by:	joshruehlig@gmail.com (maintainer)

Changes:
  head/news/sabnzbdplus/Makefile
  head/news/sabnzbdplus/distinfo
  head/news/sabnzbdplus/pkg-plist

Thanks for your review! ok will do.