Bug 215223 - www/py-bottle-cork : update sqlalchemy dependency
Summary: www/py-bottle-cork : update sqlalchemy dependency
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Olivier Cochard
URL:
Keywords: needs-qa, patch-ready
Depends on:
Blocks:
 
Reported: 2016-12-11 16:51 UTC by Rene Ladan
Modified: 2016-12-16 13:44 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (olivier)

Attachments
patch to update sqlalchemy dependency (594 bytes, patch)
2016-12-11 16:51 UTC, Rene Ladan 		no flags Details | Diff
new patch (739 bytes, patch)
2016-12-12 21:04 UTC, Rene Ladan 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rene Ladan freebsd_committer freebsd_triage 2016-12-11 16:51:54 UTC 
Created attachment 177879 [details]
patch to update sqlalchemy dependency

Update the sqlalchemy dependency from 0.7 to 1.0, as the former expired both in the Ports Tree and upstream.

The port builds fine, but preferably needs run-time testing.
Comment 1 Olivier Cochard freebsd_committer freebsd_triage 2016-12-12 10:49:37 UTC 
Should we increase PORT_REVISION too ?
Comment 2 Rene Ladan freebsd_committer freebsd_triage 2016-12-12 21:04:16 UTC 
Created attachment 177919 [details]
new patch
Comment 3 Rene Ladan freebsd_committer freebsd_triage 2016-12-12 21:04:28 UTC 
I didn't bump it at first because it would only apply to builds with non-default options, but thinking about it, such environments would never catch the update.
Although MOVED would instruct portmaster/portupgrade/... to switch to sqlalchemy10, they wouldn't rebuild this port so it would end up with a broken dependency.

So yes, it is better to bump PORTREVISION. New patch attached.
Comment 4 commit-hook freebsd_committer freebsd_triage 2016-12-16 13:42:35 UTC 
A commit references this bug:

Author: olivier
Date: Fri Dec 16 13:42:11 UTC 2016
New revision: 428678
URL: https://svnweb.freebsd.org/changeset/ports/428678

Log:
  Update sqlalchemy dependency

  PR:		215223
  Submitted by:	rene
  Approved by:	tabthorpe
  Differential Revision:	https://reviews.freebsd.org/D8799

Changes:
  head/www/py-bottle-cork/Makefile
Comment 5 Olivier Cochard freebsd_committer freebsd_triage 2016-12-16 13:44:33 UTC 
Thank Rene!