Bug 215252 - audio/libbs2b: drop unused dependencies
Summary: audio/libbs2b: drop unused dependencies
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Nikolai Lifanov
URL:
Keywords: patch, patch-ready
Depends on: 170034
Blocks:
  Show dependency tree / graph
 
Reported: 2016-12-12 16:16 UTC by Jan Beich
Modified: 2016-12-22 22:43 UTC (History)
2 users (show)

See Also:
bugzilla: maintainer-feedback? (liangtai.s16)

Attachments
v1 (1.05 KB, patch)
2016-12-12 16:16 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2016-12-12 16:16:28 UTC 
Created attachment 177914 [details]
v1

libbs2b doesn't directly link against anything but libsndfile. And none of supported FreeBSD releases bootleg indirect dependencies.

$ readelf -d /usr/local/lib/libbs2b.so | fgrep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libc++.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libcxxrt.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libm.so.5]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.7]
 0x0000000000000001 (NEEDED)             Shared library: [libgcc_s.so.1]

$ readelf -d /usr/local/bin/bs2bconvert | fgrep NEEDED
 0x0000000000000001 (NEEDED)             Shared library: [libsndfile.so.1]
 0x0000000000000001 (NEEDED)             Shared library: [libbs2b.so.0]
 0x0000000000000001 (NEEDED)             Shared library: [libc.so.7]

Build logs:
10.1 i386  - http://sprunge.us/LXfd
10.3 amd64 - http://sprunge.us/IVST
11.0 i386  - http://sprunge.us/YJfZ
9.3 amd64  - http://sprunge.us/BWjQ
9.3 i386   - http://sprunge.us/XFId
Comment 1 Nikolai Lifanov freebsd_committer freebsd_triage 2016-12-22 22:42:52 UTC 
Committed, thanks!
Comment 2 commit-hook freebsd_committer freebsd_triage 2016-12-22 22:43:12 UTC 
A commit references this bug:

Author: lifanov
Date: Thu Dec 22 22:42:09 UTC 2016
New revision: 429192
URL: https://svnweb.freebsd.org/changeset/ports/429192

Log:
  audio/libbs2b: back out r301301

  /usr/bin/ld no longer pulls indirect dependencies.

  PR:		215252
  Submitted by:	jbeich
  Reviewed by:	matthew
  Approved by:	matthew (mentor), liangtai.s26@gmail.com (maintainer timeout)
  Differential Revision:	https://reviews.freebsd.org/D8885

Changes:
  head/audio/libbs2b/Makefile