The Current skill-4.0 port $FreeBSD: ports/sysutils/skill/Makefile,v 1.11 2000/09/17 18:53:42 ade Exp $ Fails to build, due to the bundled Config script failing to identify the OS type correctly in the case where the word FreeBSD doesn't occur in the first line of the /etc/motd. This Config script is not needed since the appropriate values are already placed in the Makefile by patch-aa. Fix: Problem can be solved by removing the following from /usr/ports/skill/Makefile HAS_CONFIGURE= yes CONFIGURE_SCRIPT= Config pre-configure: @${CHMOD} a+x ${WRKSRC}/Config Since the values generated by the Config script are already patched into the Makefile this can be done buy applying the following patch How-To-Repeat: cd /usr/ports/sysutils/skill; make ===> Configuring for skill-4.0 Config: unknown system type: unknown ===> Script "Config" failed: here are the contents of "config.log" cat: config.log: No such file or directory *** Error code 1
I've forwarded this PR to the skill port maintainer - jonny@jonny.eng.br - along with another suggested fix - I think eliminating the configuration script is too radical a solution :) Attached is a patch to the port tree which adds a new patch, adding 4 lines to the GuessOS script to identify FreeBSD at once by the `uname -s` output. G'luck, Peter -- This sentence is false. diff -urN ports/sysutils/skill/patches/patch-ab myports/sysutils/skill/patches/patch-ab --- ports/sysutils/skill/patches/patch-ab Thu Jan 1 02:00:00 1970 +++ myports/sysutils/skill/patches/patch-ab Tue Sep 26 15:44:05 2000 @@ -0,0 +1,14 @@ +--- ./GuessOS.orig Tue May 30 05:03:08 2000 ++++ ./GuessOS Tue Sep 26 15:42:53 2000 +@@ -9,6 +9,11 @@ + # or, failing that, the location of some files. + # + ++if test "`exec 2>/dev/null; uname -s`" = "FreeBSD"; then ++ echo bsd44; ++ exit 0; ++fi ++ + case "`exec 2>/dev/null; head -2 /etc/motd`" in + *"IBM AIX Version 3"*) + OS=aix3
Hi, As the maintainer, I've analysed the options, and prefer Barry's way of fixing (removing Config). I've also contacted the author to propose fixes for a next version. BTW: Barry, next time, contact the maintainer first. I only knew about the problem because Peter came to me. Thanks in advance, Jonny -- João Carlos Mendes Luís jonny@embratel.net.br Networking Engineer jonny@jonny.eng.br Internet via Embratel jcml@ieee.org
State Changed From-To: open->closed Committed, thanks!