Bug 215581 - net/ntpa: update to 0.8.1
Summary: net/ntpa: update to 0.8.1
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Thomas Zander
URL:
Keywords: patch, patch-ready
Depends on:
Blocks:
 
Reported: 2016-12-26 15:48 UTC by Carsten Larsen
Modified: 2017-01-07 19:18 UTC (History)
1 user (show)

See Also:


Attachments
update to 0.8.1 (5.97 KB, patch)
2016-12-26 15:48 UTC, Carsten Larsen
cs: maintainer-approval+
Details | Diff
update to 0.8.1 (5.97 KB, patch)
2017-01-07 17:25 UTC, Carsten Larsen
cs: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carsten Larsen 2016-12-26 15:48:16 UTC
Created attachment 178291 [details]
update to 0.8.1

portlint:
  OK (warnings about pkg-install & pkg-deinstall)

poudriere:
  no errors


The port does currently not work with devel/newtonsoft-json. For now a local copy of the library is included in the package instead.
Comment 1 Thomas Zander freebsd_committer freebsd_triage 2017-01-04 14:00:48 UTC
This does not build:

[...]
Package NPlot was not found in the pkg-config search path.
Perhaps you should add the directory containing `NPlot.pc'
to the PKG_CONFIG_PATH environment variable
Package 'NPlot', required by 'virtual:world', not found
error CS8027: Error running pkg-config. Check the above output.
gmake[2]: *** [Makefile:898: ../bin/Ntp.Analyzer.dll] Error 1
gmake[2]: Leaving directory '/wrkdirs/usr/ports/net/ntpa/work/ntpa-0.8.1/Ntp.Analyzer'
gmake[1]: *** [Makefile:343: all-recursive] Error 1
gmake[1]: Leaving directory '/wrkdirs/usr/ports/net/ntpa/work/ntpa-0.8.1'
===> Compilation failed unexpectedly.
Comment 2 Carsten Larsen 2017-01-05 20:59:20 UTC
(In reply to Thomas Zander from comment #1)

Setting up a new build environment and investigating the issue. I did a local build with options disabled which seemed to work fine. The pkg-config dependency should have been disabled with:

CONFIGURE_ENV+= NPLOT_CFLAGS=" " NPLOT_LIBS="-r:../packages/NPlot.0.9.10.0/lib/net20/NPlot.dll"
Comment 3 Carsten Larsen 2017-01-07 17:25:33 UTC
Created attachment 178606 [details]
update to 0.8.1

Tested both with and without options enabled.
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-01-07 19:14:45 UTC
A commit references this bug:

Author: riggs
Date: Sat Jan  7 19:13:47 UTC 2017
New revision: 430823
URL: https://svnweb.freebsd.org/changeset/ports/430823

Log:
  Update to upstream version 0.8.1

  PR:		215581
  Submitted by:	cs@innolan.dk (maintainer)

Changes:
  head/net/ntpa/Makefile
  head/net/ntpa/distinfo
  head/net/ntpa/files/patch-Makefile.am
  head/net/ntpa/files/patch-Ntp.Analyzer_Makefile.am
  head/net/ntpa/files/patch-configure.ac
  head/net/ntpa/pkg-plist
Comment 5 Thomas Zander freebsd_committer freebsd_triage 2017-01-07 19:18:10 UTC
Thanks for double-checking and updating the patch!

Just a tiny adjustment. I changed GRAPH_*_DEPENDS+= to GRAPH_*_DEPENDS= since there are no other GRAPH specific dependencies.