Bug 215979 - Regression in pciconf utility in RELEASE-11.0
Summary: Regression in pciconf utility in RELEASE-11.0
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-11 20:46 UTC by David.Boyd49
Modified: 2017-01-22 11:15 UTC (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David.Boyd49 2017-01-11 20:46:53 UTC
pciconf -lv em0@pci0:6:0:0: returns the following error:

	pciconf: cannont parse selector em0:pci0:6:0:0:

This is contrary to the man page documentation which specifies that the
trailing colon is optional and ignored.

I have verified that this worked properly (as documented) in
releng/10.3.

A diff of pciconf.c between releng/11.0 and releng/10.3 show that the
"parsesel" function received a major rewrite.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-01-12 00:34:54 UTC
A commit references this bug:

Author: cem
Date: Thu Jan 12 00:34:37 UTC 2017
New revision: 311953
URL: https://svnweb.freebsd.org/changeset/base/311953

Log:
  pciconf(8): Reallow trailing colon in selectors

  Reallow device selectors to have a trailing colon, as documented in the
  manual page.  This was broken along with some unrelated cleanups in
  r295806.

  PR:		215979
  Reported by:	David Boyd <David.Boyd49 at twc.com>
  Sponsored by:	Dell EMC Isilon

Changes:
  head/usr.sbin/pciconf/pciconf.c
Comment 2 Conrad Meyer freebsd_committer freebsd_triage 2017-01-12 00:35:07 UTC
Fixed in CURRENT in r311953.  If someone wants to MFC it to 11 for 11.1, be my guest.
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-22 11:14:13 UTC
A commit references this bug:

Author: bapt
Date: Sun Jan 22 11:13:54 UTC 2017
New revision: 312619
URL: https://svnweb.freebsd.org/changeset/base/312619

Log:
  MFC r311953 (by cem)

  pciconf(8): Reallow trailing colon in selectors

  Reallow device selectors to have a trailing colon, as documented in the
  manual page.  This was broken along with some unrelated cleanups in
  r295806.

  PR:		215979
  Reported by:	David Boyd <David.Boyd49 at twc.com>
  Sponsored by:	Dell EMC Isilon

Changes:
_U  stable/11/
  stable/11/usr.sbin/pciconf/pciconf.c