Bug 216015 - www/webkit-qt4: fails to build with clang 4.0
Summary: www/webkit-qt4: fails to build with clang 4.0
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-kde (group)
URL:
Keywords: needs-patch
Depends on:
Blocks: 216008
  Show dependency tree / graph
 
Reported: 2017-01-13 07:40 UTC by Jan Beich
Modified: 2017-02-01 05:30 UTC (History)
0 users

See Also:
jbeich: maintainer-feedback? (kde)

Attachments
v0 (1.13 KB, patch)
2017-01-14 04:11 UTC, Jan Beich 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Beich freebsd_committer freebsd_triage 2017-01-13 07:40:43 UTC 
html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
    if (optionalHeight > 0)
        ~~~~~~~~~~~~~~ ^ ~

build log: http://sprunge.us/XIbJ
regressed by: https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-01-17 14:38:58 UTC 
A commit references this bug:

Author: jbeich
Date: Tue Jan 17 14:37:56 UTC 2017
New revision: 431742
URL: https://svnweb.freebsd.org/changeset/ports/431742

Log:
  www/webkit-qt4: unbreak with clang 4.0

  html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~

  PR:		216015
  Regressed by:	https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
  Obtained from:	upstream (excerpt)
  Approved by:	portmgr blanket

Changes:
  head/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-01-19 05:23:42 UTC 
A commit references this bug:

Author: jbeich
Date: Thu Jan 19 05:23:15 UTC 2017
New revision: 431846
URL: https://svnweb.freebsd.org/changeset/ports/431846

Log:
  MFH: r431742

  www/webkit-qt4: unbreak with clang 4.0

  html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~

  PR:		216015
  Regressed by:	https://github.com/llvm-mirror/clang/commit/4b6ad14285f3
  Obtained from:	upstream (excerpt)
  Approved by:	portmgr blanket
  Approved by:	ports-secteam blanket

Changes:
_U  branches/2017Q1/
  branches/2017Q1/www/webkit-qt4/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-02-01 05:30:20 UTC 
A commit references this bug:

Author: jbeich
Date: Wed Feb  1 05:29:19 UTC 2017
New revision: 432987
URL: https://svnweb.freebsd.org/changeset/ports/432987

Log:
  graphics/copperspice: unbreak with clang 4.0

  ../3rdparty/webkit/Source/WebCore/html/HTMLImageElement.cpp:77:24: error: ordered comparison between pointer and zero ('const int *' and 'int')
      if (optionalHeight > 0)
          ~~~~~~~~~~~~~~ ^ ~

  PR:		216015
  Reported by:	antoine (via exp-run)
  Obtained from:	upstream (excerpt)

Changes:
  head/graphics/copperspice/files/patch-src_3rdparty_webkit_Source_WebCore_html_HTMLImageElement.cpp