Bug 216096 - Few typos in comments in buf_ring.h
Summary: Few typos in comments in buf_ring.h
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Many People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-01-15 08:21 UTC by Bulat
Modified: 2017-01-15 18:01 UTC (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Bulat 2017-01-15 08:21:26 UTC
r309414

sys/sys/buf_ring.h

Used to return a buffer (most likely already there)
 * to the top od the ring. The caller should *not*
 * have used any dequeue to pull it out of the ring
 * but instead should have used the peek() function.
 * This is normally used where the transmit queue


 typo here -> * of a driver is full, and an MUBF must be returned.
 should be ... mbuf ..., not mubf

 * Most likely whats in the ring-buffer is what
 * is being put back (since it was not removed), but
 * sometimes the lower transmit function may have
 * done a pullup or other function that will have

 typo here -> * changed it. As an OPTIMZATION we always put it
 should be ... optimization(or optimisation)

 * back (since jhb says the store is probably cheaper),
 * if we have to do a multi-queue version we will need
 * the compare and an atomic.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-01-15 18:01:19 UTC
A commit references this bug:

Author: cem
Date: Sun Jan 15 18:00:47 UTC 2017
New revision: 312235
URL: https://svnweb.freebsd.org/changeset/base/312235

Log:
  Fix a variety of cosmetic typos and misspellings

  No functional change.

  PR:		216096, 216097, 216098, 216101, 216102, 216106, 216109, 216110
  Reported by:	Bulat <bltsrc at mail.ru>
  Sponsored by:	Dell EMC Isilon

Changes:
  head/sys/amd64/vmm/vmm_host.h
  head/sys/cam/cam_compat.h
  head/sys/cam/cam_iosched.h
  head/sys/netinet/cc/cc.h
  head/sys/sys/buf_ring.h
  head/sys/sys/bus.h
  head/sys/sys/busdma_bufalloc.h
  head/sys/sys/devmap.h
  head/sys/sys/eventvar.h
  head/sys/sys/gtaskqueue.h
  head/sys/sys/ksem.h
  head/sys/sys/pipe.h
  head/sys/sys/sockopt.h
  head/sys/sys/taskqueue.h
Comment 2 Conrad Meyer freebsd_committer freebsd_triage 2017-01-15 18:01:37 UTC
Thanks.  In the future, you can just open one PR for all the misspellings you find.  That will be easier to fix.