Bug 216342 - [patch] psm: wrong calculation for clickpad softbuttons at the top
Summary: [patch] psm: wrong calculation for clickpad softbuttons at the top
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: kern (show other bugs)
Version: CURRENT
Hardware: Any Any
: --- Affects Some People
Assignee: Oleksandr Tymoshenko
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-01-21 11:58 UTC by Val Packett
Modified: 2017-02-27 22:54 UTC (History)
1 user (show)

See Also:


Attachments
patch (585 bytes, patch)
2017-01-21 11:58 UTC, Val Packett
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Val Packett 2017-01-21 11:58:00 UTC
Created attachment 179180 [details]
patch

On laptops like the ThinkPad X240, ClickPad buttons are located at the top. The hw.psm.synaptics.softbuttons_y sysctl was supposed to allow this by setting the value to a negative one (e.g. -1700). However, the condition was wrong (double negative), and doing that placed the buttons in an unreachable area. This patch fixes that problem.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-15 02:53:44 UTC
A commit references this bug:

Author: gonzo
Date: Wed Feb 15 02:52:43 UTC 2017
New revision: 313757
URL: https://svnweb.freebsd.org/changeset/base/313757

Log:
  [psm] Fix calculation for clickpad softbuttons at the top

  On laptops like the ThinkPad X240, ClickPad buttons are located at the
  top. The hw.psm.synaptics.softbuttons_y sysctl was supposed to allow this
  by setting the value to a negative one (e.g. -1700). However, the
  condition was wrong (double negative), and doing that placed the buttons
  in an unreachable area.

  PR:		216342
  Submitted by:	Greg V <greg@unrelenting.technology>
  MFC after:	1 week

Changes:
  head/sys/dev/atkbdc/psm.c
Comment 2 commit-hook freebsd_committer freebsd_triage 2017-02-27 19:52:15 UTC
A commit references this bug:

Author: gonzo
Date: Mon Feb 27 19:51:27 UTC 2017
New revision: 314361
URL: https://svnweb.freebsd.org/changeset/base/314361

Log:
  MFC r313757:

  [psm] Fix calculation for clickpad softbuttons at the top

  On laptops like the ThinkPad X240, ClickPad buttons are located at the
  top. The hw.psm.synaptics.softbuttons_y sysctl was supposed to allow this
  by setting the value to a negative one (e.g. -1700). However, the
  condition was wrong (double negative), and doing that placed the buttons
  in an unreachable area.

  PR:		216342
  Submitted by:	Greg V <greg@unrelenting.technology>

Changes:
_U  stable/11/
  stable/11/sys/dev/atkbdc/psm.c