Bug 216829 - NanoBSD "tools" relies on mkimg revision not present before -HEAD
Summary: NanoBSD "tools" relies on mkimg revision not present before -HEAD
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: Warner Losh
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-05 17:04 UTC by karl
Modified: 2021-07-07 01:30 UTC (History)
2 users (show)

See Also:

Attachments
Patch to fix the missing "-a" flag on mkimg commands (3.28 KB, patch)
2017-02-05 17:04 UTC, karl 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description karl 2017-02-05 17:04:33 UTC 
Created attachment 179650 [details]
Patch to fix the missing "-a" flag on mkimg commands

/usr/src/tools/tools/nanobsd/embedded/common contains a series of sections that use the "mkimg" command to make the disk image.  This command includes a switch (-a) to make the active partition that is *not* present in other than -HEAD, and thus the command fails.

A workaround is available by using mdconfig to mount the image after it is built and set the active flag using gpart.  Patch attached to (1) delete the missing "-a" flag from the mkimg command and (2) mount and image and use gpart to set the active flag instead.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-02-06 06:16:42 UTC 
A commit references this bug:

Author: imp
Date: Mon Feb  6 06:15:39 UTC 2017
New revision: 313326
URL: https://svnweb.freebsd.org/changeset/base/313326

Log:
  o Add mkimg to the cross tools, and use the TMPPATH as PATH to pick up
    mkimg for building on systems like FreeBSD 11.0 that don't have my
    -a changes.
  o Set NANO_ROOT and NANO_ALTROOT for std-* since their values don't
    change when we set NANO_SLICE*.

  PR: 216829
  PR: 216830

Changes:
  head/tools/tools/nanobsd/embedded/common