Bug 216910 - [patch] contrib/dma different behavior when called as "mailq" instead of "/usr/bin/mailq"
Summary: [patch] contrib/dma different behavior when called as "mailq" instead of "/us...
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-STABLE
Hardware: Any Any
: --- Affects Some People
Assignee: freebsd-bugs (Nobody)
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-02-08 12:00 UTC by Andrej Ebert
Modified: 2017-05-22 15:42 UTC (History)
3 users (show)

See Also:
bapt: mfc-stable11?
bapt: mfc-stable10?


Attachments
patches dma.c (658 bytes, text/plain)
2017-02-08 12:00 UTC, Andrej Ebert
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrej Ebert 2017-02-08 12:00:36 UTC
Created attachment 179749 [details]
patches dma.c

We ran into problems calling dma from the nagios check_mailq script, and found out that it behaves correctly when called as just "mailq", but incorrectly when called as "/usr/bin/mailq" (with a path) for example. This patch written by my colleague Klaus-Uwe Ittner corrects this.
Comment 1 Andrej Ebert 2017-02-09 20:52:33 UTC
Just for the record, also reported this upstream:

https://github.com/corecode/dma/issues/51
Comment 2 Andrej Ebert 2017-02-10 20:52:35 UTC
Just a heads up, my pull request was approved and merged upstream:

https://github.com/corecode/dma/pull/52
Comment 3 Ed Maste freebsd_committer freebsd_triage 2017-02-22 18:21:04 UTC
Thank you for the submission and for pushing it upstream.
Comment 4 Baptiste Daroussin freebsd_committer freebsd_triage 2017-02-22 23:16:26 UTC
I'll update dma from upstream asap, thanks for your contribution
Comment 5 commit-hook freebsd_committer freebsd_triage 2017-03-01 21:36:12 UTC
A commit references this bug:

Author: bapt
Date: Wed Mar  1 21:35:25 UTC 2017
New revision: 314518
URL: https://svnweb.freebsd.org/changeset/base/314518

Log:
  Import dma snapshot from git 2017-02-10

  The only change is:
  use basename to select executable identity

  PR:		216910
  Submitted by:	Andrej Ebert <andrej@ebert.su>

Changes:
  vendor/dma/dist/dma.c
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-03-01 21:43:20 UTC
A commit references this bug:

Author: bapt
Date: Wed Mar  1 21:42:23 UTC 2017
New revision: 314520
URL: https://svnweb.freebsd.org/changeset/base/314520

Log:
  Import dma snapshot from git 2017-02-10

  The only change is:
  use basename to select executable identity

  PR:		216910
  Submitted by:	Andrej Ebert <andrej@ebert.su>

Changes:
_U  head/contrib/dma/
  head/contrib/dma/dma.c
Comment 7 Baptiste Daroussin freebsd_committer freebsd_triage 2017-03-01 21:43:50 UTC
Thanks for the contribution, I'll MFC in a couple of days
Comment 8 Andrej Ebert 2017-03-18 15:31:03 UTC
Just a ping to remind Baptiste to MFC :)
Comment 9 commit-hook freebsd_committer freebsd_triage 2017-03-26 18:07:14 UTC
A commit references this bug:

Author: bapt
Date: Sun Mar 26 18:06:22 UTC 2017
New revision: 315995
URL: https://svnweb.freebsd.org/changeset/base/315995

Log:
  MFC r314520:

  Import dma snapshot from git 2017-02-10

  The only change is:
  use basename to select executable identity

  PR:		216910
  Submitted by:	Andrej Ebert <andrej@ebert.su>

Changes:
_U  stable/11/
  stable/11/contrib/dma/dma.c