Bug 217409 - "sesutil locate all off" skips empty slots
Summary: "sesutil locate all off" skips empty slots
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: bin (show other bugs)
Version: 11.0-RELEASE
Hardware: Any Any
: --- Affects Only Me
Assignee: freebsd-bugs (Nobody)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-02-28 00:40 UTC by Alan Somers
Modified: 2017-08-25 03:27 UTC (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Somers freebsd_committer freebsd_triage 2017-02-28 00:40:57 UTC 
"sesutil locate all off" will skip empty slots.  This is a problem, because for example if you use "sesutil locate da5 on" to locate a bad drive and then remove it, you can't turn the beacon off without using a sesid.  The fault command is probably affected too, but I didn't test it.
Comment 1 Baptiste Daroussin freebsd_committer freebsd_triage 2017-03-01 20:50:15 UTC 
Yes the fault command is also affected, I do not have spare hardware right now to test and make a fix, I'll try to remember to fix that once I have hardware available in our lab
Comment 2 Allan Jude freebsd_committer freebsd_triage 2017-04-22 04:59:12 UTC 
https://reviews.freebsd.org/D10458
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-06-06 02:04:09 UTC 
A commit references this bug:

Author: allanjude
Date: Tue Jun  6 02:03:22 UTC 2017
New revision: 319610
URL: https://svnweb.freebsd.org/changeset/base/319610

Log:
  usr.sbin/sesutil: 'locate all off' does not deactivate empty slots

  PR:		217409
  Reported by:	asomers
  Reviewed by:	asomers, bapt
  MFC after:	1 week
  Sponsored by:	ScaleEngine Inc.
  Differential Revision:	https://reviews.freebsd.org/D10458

Changes:
  head/usr.sbin/sesutil/sesutil.c
Comment 4 commit-hook freebsd_committer freebsd_triage 2017-06-13 15:24:32 UTC 
A commit references this bug:

Author: allanjude
Date: Tue Jun 13 15:23:49 UTC 2017
New revision: 319901
URL: https://svnweb.freebsd.org/changeset/base/319901

Log:
  MFC r319610:
    usr.sbin/sesutil: correct 'locate all off' to deactivate empty slot LEDs

  PR:		217409
  Approved by:	re (marius)

Changes:
_U  stable/11/
  stable/11/usr.sbin/sesutil/sesutil.c