Bug 217486 - chinese/gcin: update moc-qt4 executable path
Summary: chinese/gcin: update moc-qt4 executable path
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Only Me
Assignee: Vanilla I. Shu
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-02 01:57 UTC by Yunchih Chen
Modified: 2017-03-04 15:52 UTC (History)
0 users

See Also:
bugzilla: maintainer-feedback? (vanilla)

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yunchih Chen 2017-03-02 01:57:31 UTC 
In the revision 434379[1], the path of the executable moc-qt4 has changed[2]:

%%QT_BINDIR%%/moc-qt4  ==> %%QT_BINDIR%%/moc 

This breaks gcin because the path is hard-coded in the Makefile.
The proposed patch is:

Index: chinese/gcin/Makefile
===================================================================
--- chinese/gcin/Makefile       (revision 435057)
+++ chinese/gcin/Makefile       (working copy)
@@ -41,7 +41,7 @@
                s,-ldl,,; \
                s,mandir=$$datadir,mandir=$$prefix,; \
                s,/usr/share,$$prefix/share,; \
-               s,/usr/bin/moc,${LOCALBASE}/bin/moc-qt4,; \
+               s,/usr/bin/moc,${LOCALBASE}/bin/moc,; \
                1, 300 s,gcc,$$CC,; s,gcin-$$GCIN_VERSION,gcin,; \
                /GCIN_DEBUG/ d' ${WRKSRC}/configure
        @${REINPLACE_CMD} -e 's,\/usr\/share,$$(prefix)\/share,; \


[1] https://svnweb.freebsd.org/changeset/ports/434379 
[2] https://svnweb.freebsd.org/ports/head/devel/qt4-moc/pkg-plist?r1=434380&r2=434379&pathrev=434380
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-04 15:52:13 UTC 
A commit references this bug:

Author: vanilla
Date: Sat Mar  4 15:51:24 UTC 2017
New revision: 435414
URL: https://svnweb.freebsd.org/changeset/ports/435414

Log:
  1: regen patch files.
  2: fix MOC's path.

  PR:		217486
  Submitted by:	yunchih@csie.ntu.edu.tw

Changes:
  head/chinese/gcin/Makefile
  head/chinese/gcin/files/patch-Makefile
  head/chinese/gcin/files/patch-modules__Makefile
  head/chinese/gcin/files/patch-qt4-im__Makefile