Bug 217577 - fix periodic configuration issue if MK_TCP_WRAPPERS = no
Summary: fix periodic configuration issue if MK_TCP_WRAPPERS = no
Status: Closed FIXED
Alias: None
Product: Base System
Classification: Unclassified
Component: conf (show other bugs)
Version: CURRENT
Hardware: amd64 Any
: --- Affects Many People
Assignee: Enji Cooper
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-06 09:17 UTC by Sergey
Modified: 2017-03-16 01:54 UTC (History)
1 user (show)

See Also:
ngie: mfc-stable11+
ngie: mfc-stable10+
ngie: mfc-stable9-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sergey 2017-03-06 09:17:47 UTC 
Hello.

File /usr/src/etc/periodic/security/Makefile ought to be modified so that it contains

.if ${MK_TCP_WRAPPERS} != "no"
FILES+=>900.tcpwrap
.endif

Regards,
Sergey.
Comment 1 commit-hook freebsd_committer freebsd_triage 2017-03-08 06:13:06 UTC 
A commit references this bug:

Author: ngie
Date: Wed Mar  8 06:12:16 UTC 2017
New revision: 314895
URL: https://svnweb.freebsd.org/changeset/base/314895

Log:
  Only install 900.tcpwrap if MK_INETD != "no" and MK_TCP_WRAPPERS != "no"

  It relies on output from inetd that is triggered by MK_TCP_WRAPPERS=yes.

  We need to check for both knobs being set -- otherwise the script doesn't
  have much value.

  PR:		217577
  Submitted by:	Sergey <kpect@protonmail.com> (MK_TCP_WRAPPERS piece)
  MFC after:	1 week
  Sponsored by:	Dell EMC Isilon

Changes:
  head/etc/periodic/security/Makefile
Comment 2 Sergey 2017-03-08 06:55:00 UTC 
in file /usr/src/lib/Makefile /lib/libwrap is also not removed when MK_TCP_WRAPPERS = no.
Comment 3 Enji Cooper freebsd_committer freebsd_triage 2017-03-08 06:58:37 UTC 
(In reply to Sergey from comment #2)

This is a separate issue that would cause grief for downstream consumers: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=216254 . The downstream consumers that always assume libwrap is present need to be fixed (admittedly, I've stalled this work).
Comment 4 Enji Cooper freebsd_committer freebsd_triage 2017-03-14 21:48:06 UTC 
Err... it's fixed on ^/head, but is going to be MFCed...
Comment 5 Sergey 2017-03-15 07:13:28 UTC 
(In reply to Ngie Cooper from comment #4)
That's OK )
Comment 6 commit-hook freebsd_committer freebsd_triage 2017-03-16 01:48:29 UTC 
A commit references this bug:

Author: ngie
Date: Thu Mar 16 01:48:08 UTC 2017
New revision: 315347
URL: https://svnweb.freebsd.org/changeset/base/315347

Log:
  MFC r314895:

  Only install 900.tcpwrap if MK_INETD != "no" and MK_TCP_WRAPPERS != "no"

  It relies on output from inetd that is triggered by MK_TCP_WRAPPERS=yes.

  We need to check for both knobs being set -- otherwise the script doesn't
  have much value.

  PR:		217577

Changes:
_U  stable/11/
  stable/11/etc/periodic/security/Makefile
Comment 7 commit-hook freebsd_committer freebsd_triage 2017-03-16 01:50:33 UTC 
A commit references this bug:

Author: ngie
Date: Thu Mar 16 01:50:11 UTC 2017
New revision: 315348
URL: https://svnweb.freebsd.org/changeset/base/315348

Log:
  MFC r314895:

  Only install 900.tcpwrap if MK_INETD != "no" and MK_TCP_WRAPPERS != "no"

  It relies on output from inetd that is triggered by MK_TCP_WRAPPERS=yes.

  We need to check for both knobs being set -- otherwise the script doesn't
  have much value.

  PR:		217577

Changes:
_U  stable/10/
  stable/10/etc/periodic/security/Makefile