Bug 217619 - x11/xvt: [patch] Add configure support for --enable-xgetdefault
Summary: x11/xvt: [patch] Add configure support for --enable-xgetdefault
Status: Closed FIXED
Alias: None
Product: Ports & Packages
Classification: Unclassified
Component: Individual Port(s) (show other bugs)
Version: Latest
Hardware: Any Any
: --- Affects Some People
Assignee: Alex Kozlov
URL:
Keywords: patch
Depends on:
Blocks:
 
Reported: 2017-03-07 21:09 UTC by Terry Kennedy
Modified: 2017-05-16 18:56 UTC (History)
3 users (show)

See Also:
bugzilla: maintainer-feedback? (portmaster)


Attachments
Patch to enable configuring --enable-xgetdefault (1.38 KB, text/plain)
2017-03-07 21:09 UTC, Terry Kennedy
no flags Details
svn diff for x11/xvt (superceeds user submitted patch) (1.55 KB, patch)
2017-03-23 06:02 UTC, Chris Hutchinson
portmaster: maintainer-approval+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Kennedy 2017-03-07 21:09:48 UTC
Created attachment 180609 [details]
Patch to enable configuring --enable-xgetdefault

The xvt port lacks the ability to set the --enable-xgetdefault option. This means that the port is limited to using ~/.Xdefaults or ~/.Xresources and will not use user preferences set on their X display server.

While my user feels strongly that the new option should be selected by default, I'm respecting POLA by adding it as a non-selected option.

Note: Both the build process and portlint throw a few warnings. These are pre-existing issues and may need to be addressed by someone else.
Comment 1 Chris Hutchinson 2017-03-23 06:02:59 UTC
Created attachment 181083 [details]
svn diff for x11/xvt (superceeds user submitted patch)

This patch grants the users request in this pr.
While here add needed x11 to USE_XORG

That's it.
I'm the MAINTAINER, and I approve this patch. :-)

Thanks!

--Chris
Comment 2 Terry Kennedy 2017-05-09 18:47:42 UTC
(In reply to Chris Hutchinson from comment #1)

Can we get somebody to commit this, please?
Comment 3 commit-hook freebsd_committer freebsd_triage 2017-05-16 18:56:28 UTC
A commit references this bug:

Author: ak
Date: Tue May 16 18:55:26 UTC 2017
New revision: 441048
URL: https://svnweb.freebsd.org/changeset/ports/441048

Log:
  - Add XGETDEFAULT option

  PR:	217619
  Submitted by:	Terry Kennedy <terry-freebsd@glaver.org> (original vesrion)
  Submitted by:	Chris Hutchinson <portmaster@bsdforge.com> (maintainer)

Changes:
  head/x11/xvt/Makefile